Linux kbuild/kconfig development
 help / color / mirror / Atom feed
From: Rolf Eike Beer <eb@emlix.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] kconfig: qconf: remove overloaded constructor
Date: Thu, 19 Dec 2024 08:22:03 +0100	[thread overview]
Message-ID: <2207289.irdbgypaU6@devpool47.emlix.com> (raw)
In-Reply-To: <5843611.DvuYhMxLoT@devpool47.emlix.com>

No extra implementation is needed for this variant, provide a default argument
to the matching sibling instead.

Signed-off-by: Rolf Eike Beer <eb@emlix.com>
---
 scripts/kconfig/qconf.h | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/scripts/kconfig/qconf.h b/scripts/kconfig/qconf.h
index 62ab3286d04f..1c90fec4c2da 100644
--- a/scripts/kconfig/qconf.h
+++ b/scripts/kconfig/qconf.h
@@ -114,7 +114,7 @@ public slots:
 class ConfigItem : public QTreeWidgetItem {
 	typedef class QTreeWidgetItem Parent;
 public:
-	ConfigItem(ConfigList *parent, ConfigItem *after, struct menu *m)
+	ConfigItem(ConfigList *parent, ConfigItem *after, struct menu *m = nullptr)
 	: Parent(parent, after), nextItem(0), menu(m), goParent(false)
 	{
 		init();
@@ -124,11 +124,6 @@ class ConfigItem : public QTreeWidgetItem {
 	{
 		init();
 	}
-	ConfigItem(ConfigList *parent, ConfigItem *after)
-	: Parent(parent, after), nextItem(0), menu(0), goParent(true)
-	{
-		init();
-	}
 	~ConfigItem(void);
 	void init(void);
 	void updateMenu(void);
-- 
2.47.1


-- 
Rolf Eike Beer

emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
Phone +49 (0)551 30664-0, e-mail info@emlix.com
District Court of Göttingen, Registry Number HR B 3160
Managing Directors: Heike Jordan, Dr. Uwe Kracke
VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
Office Bonn: Bachstr. 6, 53115 Bonn, Germany
http://www.emlix.com

emlix - your embedded Linux partner



  parent reply	other threads:[~2024-12-19  7:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-19  7:19 [PATCH 0/4] improve qconfig C++ code, take 2 Rolf Eike Beer
2024-12-19  7:20 ` [PATCH 1/4] kconfig: qconf: use preferred form of QString API Rolf Eike Beer
2025-01-10 16:33   ` Masahiro Yamada
2024-12-19  7:21 ` [PATCH 2/4] kconfig: qconf: use QCommandLineParser Rolf Eike Beer
2025-01-10 17:27   ` Masahiro Yamada
2024-12-19  7:22 ` Rolf Eike Beer [this message]
2025-01-10 17:29   ` [PATCH 3/4] kconfig: qconf: remove overloaded constructor Masahiro Yamada
2025-01-14 13:03     ` Rolf Eike Beer
2024-12-19  7:22 ` [PATCH 4/4] kconfig: qconf: use nullptr in C++11 code Rolf Eike Beer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2207289.irdbgypaU6@devpool47.emlix.com \
    --to=eb@emlix.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox