From: Arnd Bergmann <arnd@arndb.de>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: linux-snps-arc@lists.infradead.org,
Claudiu Zissulescu <Claudiu.Zissulescu@synopsys.com>,
Michal Marek <mmarek@suse.cz>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8
Date: Fri, 18 Mar 2016 10:52:12 +0100 [thread overview]
Message-ID: <23667289.mNa1Q2STbY@wuerfel> (raw)
In-Reply-To: <1458290783-31491-1-git-send-email-vgupta@synopsys.com>
On Friday 18 March 2016 14:16:23 Vineet Gupta wrote:
> diff --git a/arch/arc/Makefile b/arch/arc/Makefile
> index fed12f39d8ce..aeb101e8e674 100644
> --- a/arch/arc/Makefile
> +++ b/arch/arc/Makefile
> @@ -48,9 +48,14 @@ endif
> upto_gcc44 := $(call cc-ifversion, -le, 0404, y)
> atleast_gcc44 := $(call cc-ifversion, -ge, 0404, y)
> atleast_gcc48 := $(call cc-ifversion, -ge, 0408, y)
> +is_gcc48 := $(call cc-ifversion, -eq, 0408, y)
>
> cflags-$(atleast_gcc44) += -fsection-anchors
>
> +# gcc 4.8 spits out false positives for default -O3
> +# disable these for 4.8 and revisit when we upgrade to newer ver
> +cflags-$(is_gcc48) += $(call cc-disable-warning,maybe-uninitialized,)
> +
> cflags-$(CONFIG_ARC_HAS_LLSC) += -mlock
> cflags-$(CONFIG_ARC_HAS_SWAPE) += -mswape
Is this any better with gcc-4.9 or gcc-5? Maybe it's better to add the flag to
the line that adds -O3 for consistency. We do the same thing for -Os in the
global Makefile, as that triggers a similar load of warnings.
Arnd
next prev parent reply other threads:[~2016-03-18 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 8:46 [PATCH] ARC: build: Turn off -Wmaybe-uninitialized for ARC gcc 4.8 Vineet Gupta
2016-03-18 9:52 ` Arnd Bergmann [this message]
2016-03-18 10:20 ` Vineet Gupta
2016-03-18 10:29 ` Arnd Bergmann
2016-03-18 10:43 ` Vineet Gupta
2016-03-18 12:13 ` Arnd Bergmann
2016-03-18 13:01 ` Vineet Gupta
2016-03-18 13:41 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23667289.mNa1Q2STbY@wuerfel \
--to=arnd@arndb.de \
--cc=Claudiu.Zissulescu@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=geert@linux-m68k.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox