From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Masahiro Yamada <masahiroy@kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
"John (Warthog9) Hawley" <warthog9@kernel.org>
Subject: Re: [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users
Date: Fri, 26 Mar 2021 00:51:51 -0700 [thread overview]
Message-ID: <2af5ea06f8ebd20e0d3bdd51bd8a44f5fdad08d9.camel@perches.com> (raw)
In-Reply-To: <20210325095039.7202d675@gandalf.local.home>
On Thu, 2021-03-25 at 09:50 -0400, Steven Rostedt wrote:
> On Thu, 25 Mar 2021 15:20:13 +0900 Masahiro Yamada <masahiroy@kernel.org> wrote:
> >
> > The root cause of inconsistency is that
> > you mix up space-indentation and tab-indentation.
> > I do not know if it is a standard way either.
>
> This is the default way emacs has edited perl files for as long as I can
> remember (back to 1996). It became my standard of editing perl files just
> because of that. For everything else, I use tabs.
[]
> > For example, scripts/checkpatch.pl uses only tabs,
> > which I think is more robust.
>
> Probably because Joe probably uses vim ;-)
I generally use emacs. Maybe Andy Whitcroft uses vim.
For checkpatch.pl I just followed Andy's style.
get_maintainer.pl uses the 4 spaces then 1 tab style like Steven uses.
perl code can be pretty long left to right so using smaller indentation
seems useful there.
prev parent reply other threads:[~2021-03-26 8:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 21:38 [PATCH 0/2] streamline_config.pl: Fix Perl spacing Steven Rostedt
2021-03-22 21:38 ` [PATCH 1/2] streamline_config.pl: Make spacing consistent Steven Rostedt
2021-03-22 21:38 ` [PATCH 2/2] streamline_config.pl: Add softtabstop=4 for vim users Steven Rostedt
2021-03-24 6:01 ` Masahiro Yamada
2021-03-24 13:54 ` Steven Rostedt
2021-03-25 0:06 ` Steven Rostedt
2021-03-25 6:20 ` Masahiro Yamada
2021-03-25 13:50 ` Steven Rostedt
2021-03-25 14:09 ` Masahiro Yamada
2021-03-25 15:10 ` Steven Rostedt
2021-03-26 7:51 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2af5ea06f8ebd20e0d3bdd51bd8a44f5fdad08d9.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=rostedt@goodmis.org \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox