From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 658B91EDA2A; Wed, 13 Aug 2025 14:49:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755096576; cv=none; b=O7H7f0fWcIbBmlZJMnv+zJU0Kzm6oN6tyTc4t1/+lqlLdhU/MCoYW6shd/5WCAgmyH++gBj7LJeZvqNIeFcQIxEVjOX/xD+lwbjaFSwpwQBwSVMkjX6wkJ2EvIPXV8chDTz3bYUwCMqdr7/WWRALiCq6GIUyB0aRs6PE1LDiNwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755096576; c=relaxed/simple; bh=Fpd5zyhXD0W2UAVH7AVvywto09GNq+osgS1cgA+i46E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pSZQX4Jx3WERgSTx1yQ74AGsZaqwKsbf8Dtxthb9L8aIDazyfVMQ79FggIP3K+S4QTbSa4atCvmoNjjV6GbFSBgEI4jcGaVJmGNg8kUy4Ds3xVovSKFr/sC1xCtg8ANo1MfSTf7TouFWYkxRdiEJCJXx1TcCujqcBQjWerlgpYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A16EF14BF; Wed, 13 Aug 2025 07:49:25 -0700 (PDT) Received: from [10.57.1.244] (unknown [10.57.1.244]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4CB263F5A1; Wed, 13 Aug 2025 07:49:17 -0700 (PDT) Message-ID: <31bac00f-7903-46f7-a5a0-1e8f5fd8b9ab@arm.com> Date: Wed, 13 Aug 2025 15:49:15 +0100 Precedence: bulk X-Mailing-List: linux-kbuild@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 13/18] kasan: arm64: x86: Handle int3 for inline KASAN reports To: Maciej Wieczor-Retman Cc: nathan@kernel.org, arnd@arndb.de, broonie@kernel.org, Liam.Howlett@oracle.com, urezki@gmail.com, will@kernel.org, kaleshsingh@google.com, rppt@kernel.org, leitao@debian.org, coxu@redhat.com, surenb@google.com, akpm@linux-foundation.org, luto@kernel.org, jpoimboe@kernel.org, changyuanl@google.com, hpa@zytor.com, dvyukov@google.com, kas@kernel.org, corbet@lwn.net, vincenzo.frascino@arm.com, smostafa@google.com, nick.desaulniers+lkml@gmail.com, morbo@google.com, andreyknvl@gmail.com, alexander.shishkin@linux.intel.com, thiago.bauermann@linaro.org, catalin.marinas@arm.com, ryabinin.a.a@gmail.com, jan.kiszka@siemens.com, jbohac@suse.cz, dan.j.williams@intel.com, joel.granados@kernel.org, baohua@kernel.org, kevin.brodsky@arm.com, nicolas.schier@linux.dev, pcc@google.com, andriy.shevchenko@linux.intel.com, wei.liu@kernel.org, bp@alien8.de, xin@zytor.com, pankaj.gupta@amd.com, vbabka@suse.cz, glider@google.com, jgross@suse.com, kees@kernel.org, jhubbard@nvidia.com, joey.gouly@arm.com, ardb@kernel.org, thuth@redhat.com, pasha.tatashin@soleen.com, kristina.martsenko@arm.com, bigeasy@linutronix.de, lorenzo.stoakes@oracle.com, jason.andryuk@amd.com, david@redhat.com, graf@amazon.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, mark.rutland@arm.com, dave.hansen@linux.intel.com, samuel.holland@sifive.com, kbingham@kernel.org, trintaeoitogc@gmail.com, scott@os.amperecomputing.com, justinstitt@google.com, kuan-ying.lee@canonical.com, maz@kernel.org, tglx@linutronix.de, samitolvanen@google.com, mhocko@suse.com, nunodasneves@linux.microsoft.com, brgerst@gmail.com, willy@infradead.org, ubizjak@gmail.com, peterz@infradead.org, mingo@redhat.com, sohil.mehta@intel.com, linux-mm@kvack.org, linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, llvm@lists.linux.dev, kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Ada Couprie Diaz References: <9030d5a35eb5a3831319881cb8cb040aad65b7b6.1755004923.git.maciej.wieczor-retman@intel.com> From: Ada Couprie Diaz Content-Language: en-US Organization: Arm Ltd. In-Reply-To: <9030d5a35eb5a3831319881cb8cb040aad65b7b6.1755004923.git.maciej.wieczor-retman@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, On 12/08/2025 14:23, Maciej Wieczor-Retman wrote: > [...] > > Make part of that hook - which decides whether to die or recover from a > tag mismatch - arch independent to avoid duplicating a long comment on > both x86 and arm64 architectures. > > Signed-off-by: Maciej Wieczor-Retman > --- > [...] > diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c > index f528b6041f6a..b9bdabc14ad1 100644 > --- a/arch/arm64/kernel/traps.c > +++ b/arch/arm64/kernel/traps.c > @@ -1068,22 +1068,7 @@ int kasan_brk_handler(struct pt_regs *regs, unsigned long esr) > > kasan_report(addr, size, write, pc); > > - /* > - * The instrumentation allows to control whether we can proceed after > - * a crash was detected. This is done by passing the -recover flag to > - * the compiler. Disabling recovery allows to generate more compact > - * code. > - * > - * Unfortunately disabling recovery doesn't work for the kernel right > - * now. KASAN reporting is disabled in some contexts (for example when > - * the allocator accesses slab object metadata; this is controlled by > - * current->kasan_depth). All these accesses are detected by the tool, > - * even though the reports for them are not printed. > - * > - * This is something that might be fixed at some point in the future. > - */ > - if (!recover) > - die("Oops - KASAN", regs, esr); > + kasan_inline_recover(recover, "Oops - KASAN", regs, esr); It seems that `die` is missing as the last argument, otherwise CONFIG_KASAN_SW_TAGS will not build on arm64. With the fix, it builds fully without further issues. Thanks, Ada