From: Arnd Bergmann <arnd@arndb.de>
To: Nicolas Pitre <nicolas.pitre@linaro.org>
Cc: Michal Marek <mmarek@suse.cz>, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kbuild: fix ksym_dep_filter when multiple EXPORT_SYMBOL() on the same line
Date: Thu, 28 Apr 2016 23:32:33 +0200 [thread overview]
Message-ID: <3457892.00DyBUGcjQ@wuerfel> (raw)
In-Reply-To: <alpine.LFD.2.20.1604281718520.5091@knanqh.ubzr>
On Thursday 28 April 2016 17:29:42 Nicolas Pitre wrote:
> In kernel/cgroup.c there is:
>
> #define SUBSYS(_x) \
> DEFINE_STATIC_KEY_TRUE(_x ## _cgrp_subsys_enabled_key); \
> DEFINE_STATIC_KEY_TRUE(_x ## _cgrp_subsys_on_dfl_key); \
> EXPORT_SYMBOL_GPL(_x ## _cgrp_subsys_enabled_key); \
> EXPORT_SYMBOL_GPL(_x ## _cgrp_subsys_on_dfl_key);
>
> The expansion of this macro causes multiple EXPORT_SYMBOL_GPL() instances
> to appear on the same preprocessor line output, confusing the sed script
> expecting only one of them per line. Unfortunately this can't be fixed
> nicely in the sed script as sed's regexp can't do non greedy matching.
>
> Fix this by turning any semicolon into a line break before filtering.
>
> Reported-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Nicolas Pitre <nico@linaro.org>
Tested-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2016-04-28 21:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 21:29 [PATCH] kbuild: fix ksym_dep_filter when multiple EXPORT_SYMBOL() on the same line Nicolas Pitre
2016-04-28 21:32 ` Arnd Bergmann [this message]
2016-05-10 15:24 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3457892.00DyBUGcjQ@wuerfel \
--to=arnd@arndb.de \
--cc=linux-kbuild@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=nicolas.pitre@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox