public inbox for linux-kbuild@vger.kernel.org
 help / color / mirror / Atom feed
From: Martin Walch <walch.martin@web.de>
To: linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	"Yann E. MORIN" <yann.morin.1998@free.fr>,
	Michal Marek <mmarek@suse.cz>
Subject: [RESEND PATCH v2 0/2] kconfig: Remove bad inference rules expr_eliminate_dups2()
Date: Tue, 10 Jun 2014 16:31:13 +0200	[thread overview]
Message-ID: <3491939.FtiyjGE4Of@tacticalops> (raw)

This is the third time I send this patch. As I think it is an obvious
improvement, but has not been applied, please tell me what is wrong with
this patch and what I can do better.

PATCH 1: Remove expr_eliminate_dups2() and other related code.
This does not seem to actually affect the behaviour when using Kconfig files
from the mainline kernel. But there is a slight possibility that there are
configuration files in other branches or in other projects that use the Linux
Kernel configuration system that may be affected or may even rely on the
behaviour (although I did not find such a case when doing a quick check on
busybox, uClibc and openwrt). So, there is a tiny chance to break some
very exotic case (on the other hand, it is plausible that it actually fixes
any such case).

PATCH 2: When touching expr.c anyway, fix some comments and convert C99 style
comments to traditional ones.

Martin Walch (2):
  kconfig: completely remove expr_eliminate_dups2() and related code
  kconfig: trivial - adjust comments

 scripts/kconfig/expr.c | 146 +++++++------------------------------------------
 scripts/kconfig/expr.h |   3 -
 2 files changed, 19 insertions(+), 130 deletions(-)

-- 
1.8.5.5


             reply	other threads:[~2014-06-10 14:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-10 14:31 Martin Walch [this message]
2014-09-22 17:13 ` [Resending PATCH v2 0/2] kconfig: fix bad syntactic transformation Martin Walch
2014-09-22 17:13   ` [PATCH v2 1/2] kconfig: fix bad syntactic transformation in expr.c Martin Walch
2014-10-07  8:10     ` Paul Bolle
2014-10-07  9:21       ` Dirk Gouders
2014-10-11  0:20         ` Martin Walch
2014-10-11 19:07     ` Paul Bolle
2014-09-22 17:13   ` [PATCH v2 2/2] kconfig: trivial - adjust comments Martin Walch
2014-10-10 13:01     ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3491939.FtiyjGE4Of@tacticalops \
    --to=walch.martin@web.de \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.cz \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox