From: David Laight <David.Laight@ACULAB.COM>
To: 'Masahiro Yamada' <yamada.masahiro@socionext.com>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>
Cc: Vineet Gupta <vgupta@synopsys.com>,
Alexey Brodkin <abrodkin@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
linux-stable <stable@vger.kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] kbuild: use more portable 'command -v' for cc-cross-prefix
Date: Mon, 3 Jun 2019 11:16:49 +0000 [thread overview]
Message-ID: <3dcacca3f71c46cc98fa64b13a405b59@AcuMS.aculab.com> (raw)
In-Reply-To: <20190603104902.23799-1-yamada.masahiro@socionext.com>
From: Masahiro Yamada
> Sent: 03 June 2019 11:49
>
> To print the pathname that will be used by shell in the current
> environment, 'command -v' is a standardized way. [1]
>
> 'which' is also often used in scripting, but it is not portable.
All uses of 'which' should be expunged.
It is a bourne shell script that is trying to emulate a csh builtin.
It is doomed to fail in corner cases.
ISTR it has serious problems with shell functions and aliases.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2019-06-03 11:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 10:49 [PATCH] kbuild: use more portable 'command -v' for cc-cross-prefix Masahiro Yamada
2019-06-03 11:04 ` Alexey Brodkin
2019-06-03 11:14 ` David Laight
2019-06-03 11:38 ` Masahiro Yamada
2019-06-03 13:09 ` David Laight
2019-06-04 3:30 ` Masahiro Yamada
2019-06-04 9:01 ` David Laight
2019-06-04 16:55 ` Masahiro Yamada
2019-06-03 11:16 ` David Laight [this message]
2019-06-03 11:45 ` Masahiro Yamada
2019-06-03 12:43 ` David Laight
2019-06-04 3:44 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3dcacca3f71c46cc98fa64b13a405b59@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=abrodkin@synopsys.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=michal.lkml@markovi.net \
--cc=stable@vger.kernel.org \
--cc=vgupta@synopsys.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox