From: Ihor Solodrai <ihor.solodrai@linux.dev>
To: Gary Guo <gary@garyguo.net>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nsc@kernel.org>,
bpf@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next v1] scripts/gen-btf.sh: Use CONFIG_SHELL for execution
Date: Wed, 21 Jan 2026 10:30:40 -0800 [thread overview]
Message-ID: <44168005-28df-4b5b-96a7-b6b9e7494aed@linux.dev> (raw)
In-Reply-To: <DFUH7UI3MM6F.1B30NTZ5NFSKR@garyguo.net>
On 1/21/26 10:24 AM, Gary Guo wrote:
> On Wed Jan 21, 2026 at 6:16 PM GMT, Ihor Solodrai wrote:
>> According to the docs [1], kernel build scripts should be executed via
>> CONFIG_SHELL, which is sh by default.
>>
>> Fixup gen-btf.sh to be runnable with sh, and use CONFIG_SHELL at every
>> invocation site.
>>
>> See relevant discussion for context [2].
>>
>> [1] https://docs.kernel.org/kbuild/makefiles.html#script-invocation
>> [2] https://lore.kernel.org/bpf/CAADnVQ+dxmSNoJAGb6xV89ffUCKXe5CJXovXZt22nv5iYFV5mw@mail.gmail.com/
>>
>> Signed-off-by: Ihor Solodrai <ihor.solodrai@linux.dev>
>
> I can indeed build again when applying this on top of linux-next. Thanks.
>
> Tested-by: Gary Guo <gary@garyguo.net>
>
> You probably also want to carry some Reported-by, Suggested-by and Fixes tags here.
You're right. This should do it:
Reported-by: Gary Guo <gary@garyguo.net>
Suggested-by: Thomas Weißschuh <linux@weissschuh.net>
Fixes: 522397d05e7d ("resolve_btfids: Change in-place update with raw binary output")
Alexei, please lmk if I should re-send with tags.
>
>
>> [...]
next prev parent reply other threads:[~2026-01-21 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 18:16 [PATCH bpf-next v1] scripts/gen-btf.sh: Use CONFIG_SHELL for execution Ihor Solodrai
2026-01-21 18:24 ` Gary Guo
2026-01-21 18:30 ` Ihor Solodrai [this message]
2026-01-21 20:38 ` Alexei Starovoitov
2026-01-21 20:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44168005-28df-4b5b-96a7-b6b9e7494aed@linux.dev \
--to=ihor.solodrai@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=gary@garyguo.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=martin.lau@linux.dev \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox