From: Martin Kelly <martin.kelly@crowdstrike.com>
To: "masahiroy@kernel.org" <masahiroy@kernel.org>,
"ojeda@kernel.org" <ojeda@kernel.org>,
"jpoimboe@kernel.org" <jpoimboe@kernel.org>,
"pasha.tatashin@soleen.com" <pasha.tatashin@soleen.com>,
"mhiramat@kernel.org" <mhiramat@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"james.clark@arm.com" <james.clark@arm.com>,
"mpe@ellerman.id.au" <mpe@ellerman.id.au>,
"mathieu.desnoyers@efficios.com" <mathieu.desnoyers@efficios.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"rostedt@goodmis.org" <rostedt@goodmis.org>,
"nathan@kernel.org" <nathan@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
"nicolas@fjasle.eu" <nicolas@fjasle.eu>,
"surenb@google.com" <surenb@google.com>,
"npiggin@gmail.com" <npiggin@gmail.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"zhengyejian@huaweicloud.com" <zhengyejian@huaweicloud.com>,
"naveen.n.rao@linux.ibm.com" <naveen.n.rao@linux.ibm.com>,
"bp@alien8.de" <bp@alien8.de>,
"kent.overstreet@linux.dev" <kent.overstreet@linux.dev>,
"mcgrof@kernel.org" <mcgrof@kernel.org>
Cc: Amit Dang <amit.dang@crowdstrike.com>,
"linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"linux-trace-kernel@vger.kernel.org"
<linux-trace-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue
Date: Tue, 10 Dec 2024 19:15:13 +0000 [thread overview]
Message-ID: <44353f4cd4d1cc7170d006031819550b37039dd2.camel@crowdstrike.com> (raw)
In-Reply-To: <20240723063258.2240610-1-zhengyejian@huaweicloud.com>
On Tue, 2024-07-23 at 14:32 +0800, Zheng Yejian wrote:
> Background of this patch set can be found in v1:
>
> https://lore.kernel.org/all/20240613133711.2867745-1-zhengyejian1@huawei.com/
>
>
> Here add a reproduction to show the impact to livepatch:
> 1. Add following hack to make livepatch-sample.ko do patch on
> do_one_initcall()
> which has an overriden weak function behind in vmlinux, then print
> the
> actually used __fentry__ location:
>
Hi all, what is the status of this patch series? I'd really like to see
it or some other fix to this issue merged. The underlying bug is a
significant one that can cause ftrace/livepatch/BPF fentry to fail
silently. I've noticed this bug in another context[1] and realized
they're the same issue.
I'm happy to help with this patch series to address any issues as
needed.
[1]
https://lore.kernel.org/bpf/7136605d24de9b1fc62d02a355ef11c950a94153.camel@crowdstrike.com/T/#mb7e6f84ac90fa78989e9e2c3cd8d29f65a78845b
next prev parent reply other threads:[~2024-12-10 19:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 6:32 [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue Zheng Yejian
2024-07-23 6:32 ` [PATCH v2 1/5] kallsyms: Emit symbol at the holes in the text Zheng Yejian
2024-07-23 6:32 ` [PATCH v2 2/5] module: kallsyms: Determine exact function size Zheng Yejian
2024-07-23 6:32 ` [PATCH v2 3/5] ftrace: Skip invalid __fentry__ in ftrace_process_locs() Zheng Yejian
2024-07-23 6:32 ` [PATCH v2 4/5] ftrace: Fix possible out-of-bound issue " Zheng Yejian
2024-07-23 6:32 ` [PATCH v2 5/5] ftrace: Revert the FTRACE_MCOUNT_MAX_OFFSET workaround Zheng Yejian
2024-12-10 19:15 ` Martin Kelly [this message]
2024-12-10 20:01 ` [PATCH v2 0/5] kallsyms: Emit symbol for holes in text and fix weak function issue Christophe Leroy
2024-12-10 20:49 ` Martin Kelly
2024-12-12 9:52 ` Zheng Yejian
2024-12-13 19:31 ` Martin Kelly
2024-12-14 8:37 ` Zheng Yejian
2025-01-21 17:48 ` Steven Rostedt
2025-02-07 3:16 ` Zheng Yejian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44353f4cd4d1cc7170d006031819550b37039dd2.camel@crowdstrike.com \
--to=martin.kelly@crowdstrike.com \
--cc=akpm@linux-foundation.org \
--cc=amit.dang@crowdstrike.com \
--cc=bp@alien8.de \
--cc=bpf@vger.kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=james.clark@arm.com \
--cc=jpoimboe@kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=nicolas@fjasle.eu \
--cc=npiggin@gmail.com \
--cc=ojeda@kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=surenb@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhengyejian@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox