From: Randy Dunlap <rdunlap@infradead.org>
To: Rostislav Krasny <rostiprodev@gmail.com>
Cc: Nathan Chancellor <nathan@kernel.org>,
Nicolas Schier <nsc@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] kconfig: move XPM icons to separate files
Date: Tue, 16 Dec 2025 14:39:20 -0800 [thread overview]
Message-ID: <46a5f2d9-b118-4675-8372-40f9b2fc7bbe@infradead.org> (raw)
In-Reply-To: <CAKU3Xk6H0V2W2sEwfWZMrfJ11j5MvbhX34rpos1OfyA=zHoWfA@mail.gmail.com>
Hi,
On 12/16/25 12:38 PM, Rostislav Krasny wrote:
> On Tue, 16 Dec 2025 at 09:10, Randy Dunlap <rdunlap@infradead.org> wrote:
>> This worked well for me when I ran 'make gconfig'. However, when I tested
>> 'make xconfig', instead of having icons/symbols for
>> Back, Open, Save, Single View, Split View, Full View
>> I have words as listed above.
>
> I've double checked my patch again with the latest master branch of
> Linux and "make xconfig" works properly on my machine.
> Here you can see the screenshot: https://ibb.co/Q2jX9tQ
>
> I use Fedora 43 with Cinnamon DE. The Qt development package that I
> installed is qt5-qtbase-devel version 5.15.18-1.fc43 plus its
> dependencies.
> What version of Qt do you use? Did "make xconfig" work properly before
> you applied my patch?
>
Yes, "make xconfig" worked properly before applying this patch.
.qconf.cmd (generated by build) tells me I am using Qt6.
I don't see any build errors/warnings.
qt-core-devel & qt-base-common-devel are v6.10.1-1.2 from
openSUSE Tumbleweed.
>
> BTW if I install qt6-qtbase-devel (currently version 6.10.1-2.fc43)
> instead of qt5-qtbase-devel it fails on compilation, but this is a
> completely different problem that existed even before my changes. I
> will try to fix it later, it seems like a wrong include path.
>
> $ make xconfig
> HOSTCXX scripts/kconfig/qconf.o
> scripts/kconfig/qconf.cc:7:10: fatal error: QAction: No such file or directory
> 7 | #include <QAction>
> | ^~~~~~~~~
> compilation terminated.
> make[2]: *** [scripts/Makefile.host:148: scripts/kconfig/qconf.o] Error 1
> make[1]: *** [/home/huligan/develop/linux/Makefile:742: xconfig] Error 2
> make: *** [Makefile:248: __sub-make] Error 2
--
~Randy
next prev parent reply other threads:[~2025-12-16 23:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-13 14:09 [PATCH v2 0/1] kconfig: move XPM icons to separate files Rostislav Krasny
2025-12-13 14:09 ` [PATCH v2 1/1] " Rostislav Krasny
2025-12-16 7:10 ` Randy Dunlap
2025-12-16 20:38 ` Rostislav Krasny
2025-12-16 22:39 ` Randy Dunlap [this message]
2025-12-17 1:54 ` [PATCH v3 0/1] " Rostislav Krasny
2025-12-17 1:54 ` [PATCH v3 1/1] " Rostislav Krasny
2025-12-17 2:02 ` Randy Dunlap
2025-12-17 2:06 ` [PATCH v3 0/1] " Randy Dunlap
2025-12-19 20:39 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46a5f2d9-b118-4675-8372-40f9b2fc7bbe@infradead.org \
--to=rdunlap@infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=nsc@kernel.org \
--cc=rostiprodev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox