From: Randy Dunlap <randy.dunlap@oracle.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>, linux-kbuild@vger.kernel.org
Subject: Re: [2.6 patch] kconfig-language.txt: remove bogus hint
Date: Sun, 04 May 2008 10:55:19 -0700 [thread overview]
Message-ID: <481DF887.5030101@oracle.com> (raw)
In-Reply-To: <20080504175121.GN5838@cs181133002.pp.htv.fi>
Adrian Bunk wrote:
> On Sun, May 04, 2008 at 10:25:57AM -0700, Randy Dunlap wrote:
>> Sam Ravnborg wrote:
>>> On Sun, May 04, 2008 at 03:10:14PM +0300, Adrian Bunk wrote:
>>>> On Sun, May 04, 2008 at 01:27:41PM +0200, Sam Ravnborg wrote:
>>>>> On Sun, May 04, 2008 at 11:01:37AM +0300, Adrian Bunk wrote:
>>>>>> On Sun, May 04, 2008 at 08:17:41AM +0200, Sam Ravnborg wrote:
>>>>>>> On Sun, May 04, 2008 at 02:15:35AM +0300, Adrian Bunk wrote:
>>>>>>>> This kconfig construct described here is required in a
>>>>>>>> different and much more complicated situation.
>>>>>>> Please elaborate...
>>>>>> In the hint C is described as a tristate.
>>>>>>
>>>>>> But you need this idiom only when A is a tristate and C is a bool.
>>>>> Thats another case.
>>>>> What is described is following simple situation:
>>>>>
>>>>> config FOO
>>>>> bool "Modules"
>>>>> option modules
>>>>>
>>>>> config A
>>>>> tristate "a"
>>>>>
>>>>> config B
>>>>> tristate "b"
>>>>> depends on A
>>>>>
>>>>> config C
>>>>> tristate "c"
>>>>> depends on B
>>>>> depends on A = y || A = B
>>>>>
>>>>>
>>>>> C uses a symbol defined by A - let us name it foo().
>>>>> If C is build-in and A is a module => link error - unable to
>>>>> resolve foo.
>>>>>
>>>>> So we say: if A is buildin C may be built-in or module.
>>>>> if A is a module C may not be built-in.
>>>>>
>>>>> This is what this hint describes.
>>>> In your example C does not need any dependency on A at all since it
>>>> is already handled through the dependency chain C->B->A.
>>> You are right.
>>> Randy - what problem was it this text tried to describe/solve?
>> I thought that it was related to USB_STORAGE, but I don't find it
>> in current kernels.
>>
>> If the text is misleading, it should be yanked, of course.
>> And other places checked, e.g.:
>> ...
>
> The idiom has use cases, but you need the following prerequisites:
> - A and B are tristates
> - B does not depend on A
> - C is a bool with the semantics "enable feature C in B"
>
> And I doubt you can put that into a useful hint.
OK, sounds like the patch is good then.
--
~Randy
next prev parent reply other threads:[~2008-05-04 18:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-03 23:15 [2.6 patch] kconfig-language.txt: remove bogus hint Adrian Bunk
2008-05-04 6:17 ` Sam Ravnborg
2008-05-04 8:01 ` Adrian Bunk
2008-05-04 11:27 ` Sam Ravnborg
2008-05-04 12:10 ` Adrian Bunk
2008-05-04 12:26 ` Sam Ravnborg
2008-05-04 17:25 ` Randy Dunlap
2008-05-04 17:51 ` Adrian Bunk
2008-05-04 17:55 ` Randy Dunlap [this message]
2008-05-04 19:08 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=481DF887.5030101@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=bunk@kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox