Re: [PATCH 1/7] kconfig: qconf: use QByteArray API instead of manually constructing a string

Rolf Eike Beer
2024-10-24T07:02:31Z

[-- Attachment #1: Type: text/plain, Size: 1462 bytes --]

On Mittwoch, 23. Oktober 2024 21:07:41 Mitteleuropäische Sommerzeit Masahiro
Yamada wrote:
> On Thu, Oct 24, 2024 at 1:37 AM Masahiro Yamada <masahiroy@kernel.org>
wrote:
> > On Wed, Oct 23, 2024 at 3:29 PM Rolf Eike Beer <eb@emlix.com> wrote:
> > > Using a naked char[] here isn't necessary as QByteArray has a nice API
> > > for all of this. Calling constData() will also always return a
> > > 0-terminated string so no further handling is required. And then the
> > > whole manual memory handling can go away as QByteArray will care for
> > > this when it goes out of scope.
> > >
> > > Signed-off-by: Rolf Eike Beer <eb@emlix.com>
> > > ---
> >
> > I do not need this patch because I can refactor this function even deeper.
> >
> > I have locally kept several clean-up patches, but I have not got around to
> > submitting them.
> >
> > I will send some of them later.
>
> https://lore.kernel.org/linux-kbuild/20241023181823.138524-12-masahiroy@kern
> el.org/T/#u

Even better, thanks!
--
Rolf Eike Beer

emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
Phone +49 (0)551 30664-0, e-mail info@emlix.com
District Court of Göttingen, Registry Number HR B 3160
Managing Directors: Heike Jordan, Dr. Uwe Kracke
VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
Office Bonn: Bachstr. 6, 53115 Bonn, Germany
http://www.emlix.com

emlix - your embedded Linux partner

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 313 bytes --]