Re: [PATCH 5/7] kconfig: qconf: use nullptr in C++11 code

Rolf Eike Beer
2024-10-24T07:05:10Z

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

On Mittwoch, 23. Oktober 2024 18:41:09 Mitteleuropäische Sommerzeit Masahiro
Yamada wrote:
> On Wed, Oct 23, 2024 at 3:35 PM Rolf Eike Beer <eb@emlix.com> wrote:
> > This is type safe as it can't be accidentially assigned to something not a
> > pointer.
>
> This is incomplete because there are more call sites that use
> 0 instead of nullptr.
>
> For example, you can replace nextItem(0) with nextItem(nullptr)
>
> Anyway, I do not need this patch for now because qconf is
> under refactoring, and I will remove a lot of code.
>
> Please come back with a more comprehensive patch
> some months later if you are still interested.

This was just some obvious cases I came accross, nothing complete. If you are
going to touch code anyway I personally would recommend using nullptr whenever
you touch that things anyway and maybe someone can clean up the rest later.
But this is nothing that does any change in behavior, so I'm fine with dropping
it.

Regards,

Eike
--
Rolf Eike Beer

emlix GmbH
Headquarters: Berliner Str. 12, 37073 Göttingen, Germany
Phone +49 (0)551 30664-0, e-mail info@emlix.com
District Court of Göttingen, Registry Number HR B 3160
Managing Directors: Heike Jordan, Dr. Uwe Kracke
VAT ID No. DE 205 198 055
Office Berlin: Panoramastr. 1, 10178 Berlin, Germany
Office Bonn: Bachstr. 6, 53115 Bonn, Germany
http://www.emlix.com

emlix - your embedded Linux partner

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 313 bytes --]