From: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
linux-kbuild@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [RFC Patch 0/5] gcov: integrate gcov into kbuild
Date: Mon, 07 Sep 2009 10:24:52 +0200 [thread overview]
Message-ID: <4AA4C354.4040002@linux.vnet.ibm.com> (raw)
In-Reply-To: <20090904012755.3749.69645.sendpatchset@localhost.localdomain>
Amerigo Wang wrote:
> This patchset is mainly to integrate gcov into kbuild system, so that
> we can use "make foo/bar.c.gcov" to get the gcov files.
> Also moves the useful scripts in gcov.txt into tools/gcov/ direcotry.
Interesting approach - this should definitely make it more easy for
developers to get coverage data for their code. A couple of
thoughts/observations:
- does not work when compiling with a separate build directory (make O=)
/sys/kernel/debug/gcov//mnt/out//mnt/linux-2.6.gcno:cannot open graph file
make[2]: *** [init/main.c.gcov] Error 1
make[1]: *** [init/main.c.gcov] Error 2
make: *** [sub-make] Error 2
This is most likely due to target_base_name being an absolute path
(relative to srctree) in case build and source directories are different.
- gcov call should use option -p, otherwise gcov may overwrite .gcov
files if a .c file includes two .h files from different directories.
- an option to generate .gcov files for all .c files in a subdirectory
would be nice
Regards,
Peter Oberparleiter
next prev parent reply other threads:[~2009-09-07 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 1:25 [RFC Patch 0/5] gcov: integrate gcov into kbuild Amerigo Wang
2009-09-04 1:25 ` [Patch 1/5] gitignore: add .gcov files Amerigo Wang
2009-09-04 1:25 ` [Patch 2/5] Makefile: clean " Amerigo Wang
2009-09-04 1:25 ` [Patch 3/5] doc: move the scripts in gcov.txt to tools/gcov/ Amerigo Wang
2009-09-04 1:25 ` [Patch 4/5] scripts: add gen_gcov.sh Amerigo Wang
2009-09-04 1:26 ` [Patch 5/5] Makefile: implement "make foo.c.gcov" Amerigo Wang
2009-09-07 8:24 ` Peter Oberparleiter [this message]
2009-09-07 9:58 ` [RFC Patch 0/5] gcov: integrate gcov into kbuild Amerigo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA4C354.4040002@linux.vnet.ibm.com \
--to=oberpar@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).