From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:5570 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752516AbZIGJ5T (ORCPT ); Mon, 7 Sep 2009 05:57:19 -0400 Message-ID: <4AA4D95E.40105@redhat.com> Date: Mon, 07 Sep 2009 17:58:54 +0800 From: Amerigo Wang MIME-Version: 1.0 Subject: Re: [RFC Patch 0/5] gcov: integrate gcov into kbuild References: <20090904012755.3749.69645.sendpatchset@localhost.localdomain> <4AA4C354.4040002@linux.vnet.ibm.com> In-Reply-To: <4AA4C354.4040002@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Peter Oberparleiter Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-kbuild@vger.kernel.org, Sam Ravnborg Peter Oberparleiter wrote: > Amerigo Wang wrote: >> This patchset is mainly to integrate gcov into kbuild system, so that >> we can use "make foo/bar.c.gcov" to get the gcov files. >> Also moves the useful scripts in gcov.txt into tools/gcov/ direcotry. > > Interesting approach - this should definitely make it more easy for > developers to get coverage data for their code. A couple of > thoughts/observations: Thanks! > > - does not work when compiling with a separate build directory (make O=) > > /sys/kernel/debug/gcov//mnt/out//mnt/linux-2.6.gcno:cannot open graph file > make[2]: *** [init/main.c.gcov] Error 1 > make[1]: *** [init/main.c.gcov] Error 2 > make: *** [sub-make] Error 2 > > This is most likely due to target_base_name being an absolute path > (relative to srctree) in case build and source directories are different. > Hmm, yeah, I will fix it. > - gcov call should use option -p, otherwise gcov may overwrite .gcov > files if a .c file includes two .h files from different directories. Ok. > - an option to generate .gcov files for all .c files in a subdirectory > would be nice Nice idea! I will add this. Thank you, I will update and resend them!