From: Michal Marek <mmarek@suse.cz>
To: "\"Vadim Bendebury (вб)\"" <vbendeb@google.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] wrap long help lines
Date: Mon, 14 Dec 2009 15:19:32 +0100 [thread overview]
Message-ID: <4B264974.7050108@suse.cz> (raw)
In-Reply-To: <3b09bd800912121959r2f6dba7dt9d62b5af74123deb@mail.gmail.com>
On 13.12.2009 04:59, Vadim Bendebury (вб) wrote:
> 2009/12/12 Michal Marek <mmarek@suse.cz>:
>>> What do you think of mconf:show_help() before invoking
>>> show_help_text() - is it the right spot to plug this in? Do you have a
>>> suggestion?>
>>
>> If you look at the expr_print() prototype, it takes a pointer to a
>> callback and a data argument. This callback gets repeatedly called to
>> store or display parts of the text. So you could create a new callback
>> that pastes the parts together and inserts a newline if needed. That
>> way, you don't have to memcpy() the text around afterwards.
>>
>
> expr_print() gets called through expr_gstr_print() from three
> different places in menu.c, how would I limit the scope of this change
> to the case of help message display only? I think this change should
> only affect help messages - don't you agree?
AFAICS all three are called from within menu_get_ext_help() only.
Michal
next prev parent reply other threads:[~2009-12-14 14:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-11 17:01 [PATCH] wrap long help lines Vadim Bendebury (вб)
2009-12-12 11:27 ` Michal Marek
2009-12-13 3:59 ` Vadim Bendebury (вб)
2009-12-14 14:19 ` Michal Marek [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-12-11 5:14 Vadim Bendebury (вб)
2009-12-10 16:36 [PATCH} " Vadim Bendebury
2009-12-10 16:57 ` Randy Dunlap
2009-12-10 17:13 ` Vadim Bendebury (вб)
2009-12-11 14:34 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B264974.7050108@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=vbendeb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).