linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: "\"Vadim Bendebury (вб)\"" <vbendeb@google.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] wrap long help lines, take two
Date: Wed, 16 Dec 2009 13:02:01 +0100	[thread overview]
Message-ID: <4B28CC39.9010307@suse.cz> (raw)
In-Reply-To: <3b09bd800912152056g40fab3f9q76aef60ccf525bd0@mail.gmail.com>

On 16.12.2009 05:56, Vadim Bendebury (вб) wrote:
> 2009/12/15 Michal Marek <mmarek@suse.cz>:
>> struct somename {
>>  struct gstr *gstr;
>>  int width;
>>  /* other bookkeeping stuff like last_line_length */
>> }
>>
>> Then expr_gstr_print would just initialize an instance of this structure
>> and pass it to expr_print as the callback argument.
> 
> I first thought about it, but decided against it, because the way it
> is now it is a much more contained change. Yes, recalculating string
> length every time is excessive, but in this particular case it is
> harmless.I am also worried of the string modified elsewhere bypassing
> the print helper function, which would take things out of sync and
> cause corrupted data.

expr_print() only sees a void pointer, so it can't modify any data
hidden behind it. But I don't care, do it as you like, just please move
the ncurses calls to menuconfig.

Michal

  reply	other threads:[~2009-12-16 12:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-15  6:46 [PATCH] wrap long help lines, take two Vadim Bendebury (вб)
2009-12-15 13:33 ` Michal Marek
2009-12-16  4:56   ` Vadim Bendebury (вб)
2009-12-16 12:02     ` Michal Marek [this message]
2009-12-20  8:29       ` Vadim Bendebury (вб)
2010-01-06 20:48         ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B28CC39.9010307@suse.cz \
    --to=mmarek@suse.cz \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=vbendeb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).