From: Michal Marek <mmarek@suse.cz>
To: "\"Vadim Bendebury (вб)\"" <vbendeb@google.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] wrap long help lines, take two
Date: Wed, 06 Jan 2010 21:48:48 +0100 [thread overview]
Message-ID: <4B44F730.4070800@suse.cz> (raw)
In-Reply-To: <3b09bd800912200029u24764aeje3063fb32de0fa90@mail.gmail.com>
Vadim Bendebury (вб) napsal(a):
> Michal I looked at it a bit more, it seems that passing the width as
> an argument to expr_gstr_print() is not such a good idea, especially
> since it needs to originate in mconf.c:show_help() and make it all the
> way to expr.c:expr_print_gstr_helper() - it's quite a few nested calls
> where the argument needs to propagate through.
>
> I ended up modifying the gstr structure adding a field to specify the
> max width. It is excessive for other than mconf modes, but it seems a
> small price to pay to get a smallest contained change.
>
> Please let me know what you think and if I need to resend the patch in
> a separate email:
Hi Vadim,
sorry for the delay. Yes this patch looks ok, I added it to the kbuild tree.
Thanks!
Michal
prev parent reply other threads:[~2010-01-06 20:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 6:46 [PATCH] wrap long help lines, take two Vadim Bendebury (вб)
2009-12-15 13:33 ` Michal Marek
2009-12-16 4:56 ` Vadim Bendebury (вб)
2009-12-16 12:02 ` Michal Marek
2009-12-20 8:29 ` Vadim Bendebury (вб)
2010-01-06 20:48 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B44F730.4070800@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=vbendeb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).