From: Michal Marek <mmarek@suse.cz>
To: John Saalwaechter <saalwaechter@gmail.com>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] scripts: use %_tmppath in "make rpm-pkg"
Date: Mon, 01 Feb 2010 13:52:02 +0100 [thread overview]
Message-ID: <4B66CE72.1020003@suse.cz> (raw)
In-Reply-To: <506c8f0b1001311618i3b8f72c5w9321e3ef26413a20@mail.gmail.com>
On 1.2.2010 01:18, John Saalwaechter wrote:
> The mkspec script hardcodes "/var/tmp" into the generated rpm spec file's
> BuildRoot. The user, however, may have a custom setting for %_tmppath,
> which should be used in BuildRoot. This patch changes mkspec's
> BuildRoot output to appropriately use %_tmppath.
Thanks, applied. Please CC linux-kbuild@ on changes like this.
Michal
> Signed-off-by: John Saalwaechter <saalwaechter@gmail.com>
> ---
> diff -uprN a/scripts/package/mkspec b/scripts/package/mkspec
> --- a/scripts/package/mkspec 2010-01-28 15:06:20.000000000 -0800
> +++ b/scripts/package/mkspec 2010-01-31 15:46:23.815300460 -0800
> @@ -39,7 +39,7 @@ if ! $PREBUILT; then
> echo "Source: kernel-$__KERNELRELEASE.tar.gz"
> fi
>
> -echo "BuildRoot: /var/tmp/%{name}-%{PACKAGE_VERSION}-root"
> +echo "BuildRoot: %{_tmppath}/%{name}-%{PACKAGE_VERSION}-root"
> echo "Provides: $PROVIDES"
> echo "%define __spec_install_post /usr/lib/rpm/brp-compress || :"
> echo "%define debug_package %{nil}"
parent reply other threads:[~2010-02-01 12:52 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <506c8f0b1001311618i3b8f72c5w9321e3ef26413a20@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B66CE72.1020003@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saalwaechter@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).