Re: [PATCH 1/7] Add a target to use the Coccinelle checker

Nicolas Palix
2010-07-02T20:58:51Z

On Friday 02 July 2010 15:52:50 Kulikov Vasiliy wrote:
> On Wed, Jun 30, 2010 at 23:52 +0200, Nicolas Palix wrote:
> > On Wednesday 30 June 2010 20:58:54 Kulikov Vasiliy wrote:
> > > > +if [ "$COCCI" = "" ] ; then
> > > > + for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> > > > + coccinelle $f $srctree;
> > > > + done
> > > > +else
> > > > + coccinelle $COCCI $srctree
> > > > +fi
> > >
> > > I think it is more usefull to use $M instead of $srctree to run simple
> > > 'make coccicheck'.
> >
> > What is the purpose of $M ?
> >
> > I submitted an incremental patch to add support for $C.
>
> From root Makefile:
> # Use make M=dir to specify directory of external module to build
> # Old syntax make ... SUBDIRS=$PWD is still supported
> # Setting the environment variable KBUILD_EXTMOD take precedence
>
> So, I compile all local modules as smth like
> make -C ../../.. M=$PWD CONFIG_SMTH=m modules
>
> If coccinelle is started as 'coccinelle $COCCI $M' then it checks only in
> directory tree with $M root.

That would be great indeed. And we can still use $srctree as a default
value if $M is not set. Coccinelle already support this scheme with the
combination of -dir and -patch, so the paths in the generated patches/messages
can be fixed.

Kulikov, would you like to make the patch ?

> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--
Nicolas Palix
Web: http://www.diku.dk/~npalix/