Re: [PATCH 1/7] Add a target to use the Coccinelle checker

Nicolas Palix
2010-06-30T21:52:42Z

On Wednesday 30 June 2010 20:58:54 Kulikov Vasiliy wrote:
> Hi,
>
> On Sun, Jun 06, 2010 at 17:15 +0200, Nicolas Palix wrote:
> > + echo ' The semantic patch that makes this change is available'
> > + echo " in $FILE."
> > + echo ''
> > + echo ' More information about semantic patching is available at'
> > + echo ' http://coccinelle.lip6.fr/'
> > + echo ''
> > +
> > + $SPATCH -D $MODE -very_quiet -sp_file $COCCI $OPT -dir $DIR
>
> Here I've got output:
>
> /usr/lib/coccinelle/spatch: unknown option `-very_quiet'.
> Usage: spatch -sp_file <SP> <infile> [-o <outfile>] [-iso_file <iso>] [options]
> Options are:
> [...]
>
>
> I use ubuntu Lucid 10.04 as said in Documentation/coccinelle.txt.
>
> $ LANG=C apt-cache policy coccinelle
> [...]
> Installed: 0.2.0.deb-1ubuntu2
> [...]
>
>
> If I delete -very_quiet then It runs OK, but output is not ommited:

Indeed, I just checked that. This option has been added in 0.2.1
which was not ported from Debian before the feature freeze of Ubuntu Lucid :(

>
> init_defs_builtins: /usr/share/coccinelle/standard.h
> HANDLING: /home/vasya/dev/linux-next/security/min_addr.c
> HANDLING: /home/vasya/dev/linux-next/security/keys/proc.c
> HANDLING: /home/vasya/dev/linux-next/security/keys/keyring.c
> HANDLING: /home/vasya/dev/linux-next/security/keys/gc.c
> HANDLING: /home/vasya/dev/linux-next/security/keys/process_keys.c
> HANDLING: /home/vasya/dev/linux-next/security/keys/request_key_auth.c
> [...]
>
>
> > +if [ "$COCCI" = "" ] ; then
> > + for f in `find $srctree/scripts/coccinelle/ -name '*.cocci' -type f | sort`; do
> > + coccinelle $f $srctree;
> > + done
> > +else
> > + coccinelle $COCCI $srctree
> > +fi
>
> I think it is more usefull to use $M instead of $srctree to run simple
> 'make coccicheck'.

What is the purpose of $M ?

I submitted an incremental patch to add support for $C.

> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>

--
Nicolas Palix
Tel: (+33) 1 44 27 87 25
Tel: (+33) 6 81 07 91 72
Web: http://www.diku.dk/~npalix/