[GIT] kbuild setlocalversion fix

[GIT] kbuild setlocalversion fix

[Michal Marek]

Hi Linus,

There is a fix to the Makefile not to run scripts/setlocalversion and
various git commands on every invocation. This was also the case
previously with CONFIG_LOCALVERSION_AUTO=y, but after 85a256d (kbuild:
improve version string logic) it happens during every build. Dmitry
Torokhov complained that make install in a sshfs-mounted tree takes
extremely long, it also goes against the idea that root should only run
the necessary minimum of commands. The first patch has been in
linux-next for a couple of days and I got no complaints, the second one
is just a minor fix over it and should be safe.

Michal

The following changes since commit d5eda75f3a6a08f5a3644764a88d288e62e7823d:

  kbuild: fix LOCALVERSION handling to match description (2010-06-15 12:45:40 +0200)

are available in the git repository at:
  git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6.git rc-fixes

Michal Marek (3):
      kbuild: Clean up and speed up the localversion logic
      kbuild: Propagate LOCALVERSION= down to scripts/setlocalversion
      Merge branch 'setlocalversion-speedup' into kbuild/rc-fixes

 Makefile                 |   72 +------------------
 scripts/package/Makefile |    2 +-
 scripts/setlocalversion  |  179 ++++++++++++++++++++++++++++++++++------------
 3 files changed, 134 insertions(+), 119 deletions(-)

Re: [GIT] kbuild setlocalversion fix

[H. Peter Anvin]

On 07/02/2010 05:10 AM, Michal Marek wrote:
> Hi Linus,
> 
> There is a fix to the Makefile not to run scripts/setlocalversion and
> various git commands on every invocation. This was also the case
> previously with CONFIG_LOCALVERSION_AUTO=y, but after 85a256d (kbuild:
> improve version string logic) it happens during every build. Dmitry
> Torokhov complained that make install in a sshfs-mounted tree takes
> extremely long, it also goes against the idea that root should only run
> the necessary minimum of commands. The first patch has been in
> linux-next for a couple of days and I got no complaints, the second one
> is just a minor fix over it and should be safe.
> 

Building 2.6.35-rc4 with O= I get a bunch of:

/bin/sh: scripts/setlocalversion: No such file or directory

	-hpa