From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:56948 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750969Ab0HFTvv (ORCPT ); Fri, 6 Aug 2010 15:51:51 -0400 Message-ID: <4C5C67F0.8070408@gmail.com> Date: Fri, 06 Aug 2010 12:52:16 -0700 From: "Justin P. Mattock" MIME-Version: 1.0 Subject: Re: [PATCH] kconfig: fix make oldconfig References: <20100804125156.GA23464@sepie.suse.cz> <4C5B64EA.2000804@gmail.com> <20100806051354.GA24343@merkur.ravnborg.org> <4C5BE229.1090801@suse.cz> <20100806175217.GA8944@merkur.ravnborg.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Linus Torvalds Cc: Sam Ravnborg , Michal Marek , JBeulich@novell.com, aris@redhat.com, catalin.marinas@arm.com, jacmet@sunsite.dk, lizf@cn.fujitsu.com, ulfalizer.lkml@gmail.com, zippel@linux-m68k.org, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org On 08/06/2010 11:09 AM, Linus Torvalds wrote: > On Fri, Aug 6, 2010 at 10:52 AM, Sam Ravnborg wrote: >> >> Hmm, I wonder why you call oldconfig explicitly? >> >> A plain "make -j16" executes "silentoldconfig" if there >> is any changes in a Kconfig* file or in .config. >> Just double checked and it works as I expected. >> >> So you are asked if there is any new options anyway even >> if you skip your "oldconfig" step. > > Try this: > > git clean -dqfx > make -j16> ../makes > > It doesn't work, because "make silentconfig" will say > > *** > *** You have not yet configured your kernel! > *** (missing kernel config file ".config") > *** > *** Please run some configurator (e.g. "make oldconfig" or > *** "make menuconfig" or "make xconfig"). > *** > > which is why I always run "make oldconfig". > > Sure, I could do it only when I need to, but quite frankly, it's much > easier to just always do the thing that works, rather than try > something that doesn't work, do something else, and then re-try the > thing that can fail. > > Linus > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > the above command does break over here. using the make oldconfig command seems to be working after I did the make menuconfig. Now before doing all of this I did make a copy of the entire kernel for a new system Im building(clfs) so I went into that tree and did a make oldconfig and(luckily) hit the non responsive oldconfig thing that Linus had originally posted. here is a strace of when make oldconfig was not working(with git log at the top) http://fpaste.org/317B/ and strace of a git pull today and make oldconfig does not crap out and starts asking me y/n options: http://fpaste.org/QWWn/ hope this helps with debugging and such. Justin P. Mattock