From: Michal Marek <mmarek@suse.cz>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Roman Zippel <zippel@linux-m68k.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: [RFC 1/2] kbuild: genericizes package name
Date: Mon, 16 Aug 2010 14:23:28 +0200 [thread overview]
Message-ID: <4C692DC0.7020002@suse.cz> (raw)
In-Reply-To: <4C692795.1020907@suse.cz>
Dne 16.8.2010 13:57, Michal Marek napsal(a):
> Dne 16.8.2010 06:54, Arnaud Lacombe napsal(a):
>> - sym = sym_lookup("KERNELVERSION", 0);
>> + sym = sym_lookup("PROJECTVERSION", 0);
>
> The required change to the top-level Makefile is missing. I suggest you
> rather replace "KERNELVERSION" with a macro defaulting to
> "KERNELVERSION", so that we don't have to change it in the Makefile and
> other scripts.
Maybe a cleaner way would be to use the same syntax as for
DEFCONFIG_LIST or MODULES, i.e. mark KERNELVERSION specially in the
Kconfig file:
config KERNELVERSION
string
option version env=
and then look for a symbol with this property in kconfig.
Michal
next prev parent reply other threads:[~2010-08-16 12:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 4:54 [RFC 0/2] Factor Kconfig's prefix and package name Arnaud Lacombe
2010-08-16 4:54 ` [RFC 1/2] kbuild: genericizes " Arnaud Lacombe
2010-08-16 11:57 ` Michal Marek
2010-08-16 12:23 ` Michal Marek [this message]
2010-08-16 17:26 ` Sam Ravnborg
2010-08-16 20:05 ` Michal Marek
2010-08-16 4:54 ` [RFC 2/2] kbuild: genericizes kbuild's config prefix Arnaud Lacombe
2010-08-16 12:36 ` [RFC 0/2] Factor Kconfig's prefix and package name Sam Ravnborg
2010-08-16 21:42 ` Arnaud Lacombe
2010-08-16 21:50 ` Sam Ravnborg
2010-08-17 1:12 ` Arnaud Lacombe
2010-08-17 2:19 ` Sam Ravnborg
2010-08-17 2:56 ` Arnaud Lacombe
2010-08-17 5:42 ` [PATCH] kbuild: implement the `mainmenu' directive Arnaud Lacombe
2010-08-17 5:44 ` [PATCH] kbuild: delay rootmenu prompt initialization Arnaud Lacombe
2010-08-17 5:52 ` [PATCH] kbuild: implement the `mainmenu' directive Arnaud Lacombe
2010-08-17 11:24 ` Michal Marek
2010-08-17 20:26 ` Sam Ravnborg
2010-08-18 2:28 ` Arnaud Lacombe
2010-08-17 20:34 ` Sam Ravnborg
2010-08-17 20:44 ` Arnaud Lacombe
2010-08-17 20:51 ` Sam Ravnborg
2010-08-17 6:15 ` [RFC 0/2] Factor Kconfig's prefix and package name Arnaud Lacombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C692DC0.7020002@suse.cz \
--to=mmarek@suse.cz \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox