From: Michal Marek <mmarek@suse.cz>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Arnaud Lacombe <lacombar@gmail.com>,
Roman Zippel <zippel@linux-m68k.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: [RFC 1/2] kbuild: genericizes package name
Date: Mon, 16 Aug 2010 22:05:13 +0200 [thread overview]
Message-ID: <4C6999F9.3060908@suse.cz> (raw)
In-Reply-To: <20100816172658.GA7881@merkur.ravnborg.org>
Dne 16.8.2010 19:26, Sam Ravnborg napsal(a):
> On Mon, Aug 16, 2010 at 02:23:28PM +0200, Michal Marek wrote:
>> Maybe a cleaner way would be to use the same syntax as for
>> DEFCONFIG_LIST or MODULES, i.e. mark KERNELVERSION specially in the
>> Kconfig file:
>>
>> config KERNELVERSION
>> string
>> option version env=
>>
>> and then look for a symbol with this property in kconfig.
>
> I liked my proposal better - but alas that require some kconfig changes.
Support for 'option version' would also require some kconfig changes.
> I would be glad to receive your opinion on the suggested changes before
> putting too much time on it.
I'm all for rephrasing the texts to not mention "kernel" explicitly. As
for how to tackle the KERNELVERSION symbol - I have no strong opinion
either way. Both approaches would move the knowledge about the exact
symbol name to the Kconfig files, which is good. And the version string
is only used in titlebars and banners, so kconfig does not need to know
the value. I'd leave it up to Arnaud, whichever he finds easier to
implement :-).
Michal
next prev parent reply other threads:[~2010-08-16 20:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-16 4:54 [RFC 0/2] Factor Kconfig's prefix and package name Arnaud Lacombe
2010-08-16 4:54 ` [RFC 1/2] kbuild: genericizes " Arnaud Lacombe
2010-08-16 11:57 ` Michal Marek
2010-08-16 12:23 ` Michal Marek
2010-08-16 17:26 ` Sam Ravnborg
2010-08-16 20:05 ` Michal Marek [this message]
2010-08-16 4:54 ` [RFC 2/2] kbuild: genericizes kbuild's config prefix Arnaud Lacombe
2010-08-16 12:36 ` [RFC 0/2] Factor Kconfig's prefix and package name Sam Ravnborg
2010-08-16 21:42 ` Arnaud Lacombe
2010-08-16 21:50 ` Sam Ravnborg
2010-08-17 1:12 ` Arnaud Lacombe
2010-08-17 2:19 ` Sam Ravnborg
2010-08-17 2:56 ` Arnaud Lacombe
2010-08-17 5:42 ` [PATCH] kbuild: implement the `mainmenu' directive Arnaud Lacombe
2010-08-17 5:44 ` [PATCH] kbuild: delay rootmenu prompt initialization Arnaud Lacombe
2010-08-17 5:52 ` [PATCH] kbuild: implement the `mainmenu' directive Arnaud Lacombe
2010-08-17 11:24 ` Michal Marek
2010-08-17 20:26 ` Sam Ravnborg
2010-08-18 2:28 ` Arnaud Lacombe
2010-08-17 20:34 ` Sam Ravnborg
2010-08-17 20:44 ` Arnaud Lacombe
2010-08-17 20:51 ` Sam Ravnborg
2010-08-17 6:15 ` [RFC 0/2] Factor Kconfig's prefix and package name Arnaud Lacombe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C6999F9.3060908@suse.cz \
--to=mmarek@suse.cz \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox