Re: [PATCH 1/2] Makefile: fix missing dash when using make LOCALVERSION=xxx

David Rientjes
2010-06-28T18:46:44Z

On Mon, 28 Jun 2010, Cong Wang wrote:

> But in your patch description, you said:
>
> Without CONFIG_LOCALVERSION_AUTO, "make" results in v2.6.32-rc4+
> unless the repository is at the Linux v2.6.32-rc4 commit (in which
> case the version would be v2.6.32-rc4). If "make LOCALVERSION=kbuild"
> were used, it results in v2.6.32-rc4-kbuild.
>
> So, shouldn't that be "make LOCALVERSION=-kbuild"?
>

Yup, that's what it should have said. That doesn't mean that we need to
change the long-standing behavior of LOCALVERSION= to add an implied `-',
though.