Re: [PATCH 1/2] Makefile: fix missing dash when using make LOCALVERSION=xxx

Cong Wang
2010-06-28T09:21:32Z

On 06/28/10 17:08, David Rientjes wrote:
> On Sun, 27 Jun 2010, Amerigo Wang wrote:
>
>> From: Amerigo Wang<amwang@redhat.com>
>> Date: Mon, 28 Jun 2010 10:42:28 +0800
>>
>> When I use make LOCALVERSION=local and LOCALVERSION_AUTO is not set,
>> I got "2.6.35-rc3local". It is supposed to be "2.6.35-rc3-local".
>>
>
> No, a `-' is not implied when using LOCALVERSION=.

But in your patch description, you said:

Without CONFIG_LOCALVERSION_AUTO, "make" results in v2.6.32-rc4+
unless the repository is at the Linux v2.6.32-rc4 commit (in which
case the version would be v2.6.32-rc4). If "make LOCALVERSION=kbuild"
were used, it results in v2.6.32-rc4-kbuild.

So, shouldn't that be "make LOCALVERSION=-kbuild"?

Thanks.