* [RFC] kbuild: use getopt_long(), not its _only() variant
@ 2010-08-23 16:01 Arnaud Lacombe
2010-08-31 11:23 ` Michal Marek
0 siblings, 1 reply; 4+ messages in thread
From: Arnaud Lacombe @ 2010-08-23 16:01 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Michal Marek, linux-kbuild, Arnaud Lacombe
NetBSD lacks getopt_long_only() whereas getopt_long() works just fine.
Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
---
scripts/kconfig/conf.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
index 5b7c86e..ecb16c0 100644
--- a/scripts/kconfig/conf.c
+++ b/scripts/kconfig/conf.c
@@ -466,7 +466,7 @@ int main(int ac, char **av)
bindtextdomain(PACKAGE, LOCALEDIR);
textdomain(PACKAGE);
- while ((opt = getopt_long_only(ac, av, "", long_opts, NULL)) != -1) {
+ while ((opt = getopt_long(ac, av, "", long_opts, NULL)) != -1) {
input_mode = (enum input_mode)opt;
switch (opt) {
case silentoldconfig:
--
1.7.2.30.gc37d7.dirty
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RFC] kbuild: use getopt_long(), not its _only() variant
2010-08-23 16:01 [RFC] kbuild: use getopt_long(), not its _only() variant Arnaud Lacombe
@ 2010-08-31 11:23 ` Michal Marek
2010-08-31 11:30 ` Sam Ravnborg
0 siblings, 1 reply; 4+ messages in thread
From: Michal Marek @ 2010-08-31 11:23 UTC (permalink / raw)
To: Arnaud Lacombe; +Cc: Sam Ravnborg, linux-kbuild
On Mon, Aug 23, 2010 at 12:01:24PM -0400, Arnaud Lacombe wrote:
> NetBSD lacks getopt_long_only() whereas getopt_long() works just fine.
>
> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
> ---
> scripts/kconfig/conf.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
> index 5b7c86e..ecb16c0 100644
> --- a/scripts/kconfig/conf.c
> +++ b/scripts/kconfig/conf.c
> @@ -466,7 +466,7 @@ int main(int ac, char **av)
> bindtextdomain(PACKAGE, LOCALEDIR);
> textdomain(PACKAGE);
>
> - while ((opt = getopt_long_only(ac, av, "", long_opts, NULL)) != -1) {
> + while ((opt = getopt_long(ac, av, "", long_opts, NULL)) != -1) {
> input_mode = (enum input_mode)opt;
> switch (opt) {
> case silentoldconfig:
scripts/kconfig/Makefile uses the two-dash notation, so
getopt_long_only() really isn't necessary. Applied to
kbuild-2.6.git#kconfig.
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC] kbuild: use getopt_long(), not its _only() variant
2010-08-31 11:23 ` Michal Marek
@ 2010-08-31 11:30 ` Sam Ravnborg
2010-08-31 11:35 ` Michal Marek
0 siblings, 1 reply; 4+ messages in thread
From: Sam Ravnborg @ 2010-08-31 11:30 UTC (permalink / raw)
To: Michal Marek; +Cc: Arnaud Lacombe, linux-kbuild
On Tue, Aug 31, 2010 at 01:23:53PM +0200, Michal Marek wrote:
> On Mon, Aug 23, 2010 at 12:01:24PM -0400, Arnaud Lacombe wrote:
> > NetBSD lacks getopt_long_only() whereas getopt_long() works just fine.
> >
> > Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
> > ---
> > scripts/kconfig/conf.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
> > index 5b7c86e..ecb16c0 100644
> > --- a/scripts/kconfig/conf.c
> > +++ b/scripts/kconfig/conf.c
> > @@ -466,7 +466,7 @@ int main(int ac, char **av)
> > bindtextdomain(PACKAGE, LOCALEDIR);
> > textdomain(PACKAGE);
> >
> > - while ((opt = getopt_long_only(ac, av, "", long_opts, NULL)) != -1) {
> > + while ((opt = getopt_long(ac, av, "", long_opts, NULL)) != -1) {
> > input_mode = (enum input_mode)opt;
> > switch (opt) {
> > case silentoldconfig:
>
> scripts/kconfig/Makefile uses the two-dash notation, so
> getopt_long_only() really isn't necessary. Applied to
> kbuild-2.6.git#kconfig.
Seems I forgot to do so - I had meant to ack this patch.
Thanks,
Sam
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC] kbuild: use getopt_long(), not its _only() variant
2010-08-31 11:30 ` Sam Ravnborg
@ 2010-08-31 11:35 ` Michal Marek
0 siblings, 0 replies; 4+ messages in thread
From: Michal Marek @ 2010-08-31 11:35 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: Arnaud Lacombe, linux-kbuild
On 31.8.2010 13:30, Sam Ravnborg wrote:
> On Tue, Aug 31, 2010 at 01:23:53PM +0200, Michal Marek wrote:
>> On Mon, Aug 23, 2010 at 12:01:24PM -0400, Arnaud Lacombe wrote:
>>> NetBSD lacks getopt_long_only() whereas getopt_long() works just fine.
>>>
>>> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
...
> Seems I forgot to do so - I had meant to ack this patch.
I haven't pushed it yet, so I did a git commit --amend and added your ACK.
Michal
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-08-31 11:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-23 16:01 [RFC] kbuild: use getopt_long(), not its _only() variant Arnaud Lacombe
2010-08-31 11:23 ` Michal Marek
2010-08-31 11:30 ` Sam Ravnborg
2010-08-31 11:35 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox