Re: [RFC] kbuild: use getopt_long(), not its _only() variant

Sam Ravnborg
2010-08-31T11:30:41Z

On Tue, Aug 31, 2010 at 01:23:53PM +0200, Michal Marek wrote:
> On Mon, Aug 23, 2010 at 12:01:24PM -0400, Arnaud Lacombe wrote:
> > NetBSD lacks getopt_long_only() whereas getopt_long() works just fine.
> >
> > Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
> > ---
> > scripts/kconfig/conf.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
> > index 5b7c86e..ecb16c0 100644
> > --- a/scripts/kconfig/conf.c
> > +++ b/scripts/kconfig/conf.c
> > @@ -466,7 +466,7 @@ int main(int ac, char **av)
> > bindtextdomain(PACKAGE, LOCALEDIR);
> > textdomain(PACKAGE);
> >
> > - while ((opt = getopt_long_only(ac, av, "", long_opts, NULL)) != -1) {
> > + while ((opt = getopt_long(ac, av, "", long_opts, NULL)) != -1) {
> > input_mode = (enum input_mode)opt;
> > switch (opt) {
> > case silentoldconfig:
>
> scripts/kconfig/Makefile uses the two-dash notation, so
> getopt_long_only() really isn't necessary. Applied to
> kbuild-2.6.git#kconfig.

Seems I forgot to do so - I had meant to ack this patch.

Thanks,
Sam