Re: [PATCH 2/2] [RFC] kconfig/listnewconfig: show default value of new symbel

Ben Hutchings
2010-12-22T04:44:35Z

[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]

On Tue, 2010-12-21 at 17:47 +0100, Michal Marek wrote:
> On 5.12.2010 07:35, Arnaud Lacombe wrote:
> > note: I would not mind adding the KCONFIG_VERBOSE logic.
> >
> > Original idea and implementation by Bastian Blank <waldi@debian.org>,
> > Maximilian Attems <max@stro.at> and Ben Hutchings <ben@decadent.org.uk>
> >
> > CC: Ben Hutchings <ben@decadent.org.uk>
> > Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
> > ---
> > scripts/kconfig/conf.c | 14 +++++++++++++-
> > scripts/kconfig/confdata.c | 4 ++--
> > 2 files changed, 15 insertions(+), 3 deletions(-)
> >
> > diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
> > index 5459a38..1b58129 100644
> > --- a/scripts/kconfig/conf.c
> > +++ b/scripts/kconfig/conf.c
> > @@ -411,6 +411,17 @@ conf_childs:
> > indent -= 2;
> > }
> >
> > +
> > +static void
> > +listnewconfig_print_symbol(FILE *fp, struct symbol *sym, const char *val, void *arg)
> > +{
> > + fprintf(fp, "%s%s (default: %s)\n", CONFIG_, sym->name, val);
> > +}
>
> Ben, do you have an opinion on this format versus the standard .config
> produced by your patch?
[...]

The .config format is more useful as it is then possible to copy lines
directly into a .config file. If you're going to apply Arnaud's
preceding patch (1/2) then please let me rewrite mine to apply on top of
that, rather than applying this second patch.

Ben.

--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]