From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kbuild-owner@vger.kernel.org>
Received: from cantor2.suse.de ([195.135.220.15]:42297 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750936Ab0LUQrH (ORCPT <rfc822;linux-kbuild@vger.kernel.org>);
	Tue, 21 Dec 2010 11:47:07 -0500
Message-ID: <4D10DA09.6070009@suse.cz>
Date: Tue, 21 Dec 2010 17:47:05 +0100
From: Michal Marek <mmarek@suse.cz>
MIME-Version: 1.0
Subject: Re: [PATCH 2/2] [RFC] kconfig/listnewconfig: show default value of
 new symbel
References: <1291530919-5601-1-git-send-email-lacombar@gmail.com> <1291530919-5601-2-git-send-email-lacombar@gmail.com>
In-Reply-To: <1291530919-5601-2-git-send-email-lacombar@gmail.com>
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: 7bit
Sender: linux-kbuild-owner@vger.kernel.org
List-ID: <linux-kbuild.vger.kernel.org>
To: Arnaud Lacombe <lacombar@gmail.com>
Cc: linux-kbuild@vger.kernel.org, Ben Hutchings <ben@decadent.org.uk>

On 5.12.2010 07:35, Arnaud Lacombe wrote:
> note: I would not mind adding the KCONFIG_VERBOSE logic.
> 
> Original idea and implementation by Bastian Blank <waldi@debian.org>,
> Maximilian Attems <max@stro.at> and Ben Hutchings <ben@decadent.org.uk>
> 
> CC: Ben Hutchings <ben@decadent.org.uk>
> Signed-off-by: Arnaud Lacombe <lacombar@gmail.com>
> ---
>  scripts/kconfig/conf.c     |   14 +++++++++++++-
>  scripts/kconfig/confdata.c |    4 ++--
>  2 files changed, 15 insertions(+), 3 deletions(-)
> 
> diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
> index 5459a38..1b58129 100644
> --- a/scripts/kconfig/conf.c
> +++ b/scripts/kconfig/conf.c
> @@ -411,6 +411,17 @@ conf_childs:
>  		indent -= 2;
>  }
>  
> +
> +static void
> +listnewconfig_print_symbol(FILE *fp, struct symbol *sym, const char *val, void *arg)
> +{
> +	fprintf(fp, "%s%s (default: %s)\n", CONFIG_, sym->name, val);
> +}

Ben, do you have an opinion on this format versus the standard .config
produced by your patch?

Michal
> +
> +static struct conf_printer listnewconfig_printers = {
> +	.print_symbol = listnewconfig_print_symbol,
> +};
> +
>  static void check_conf(struct menu *menu)
>  {
>  	struct symbol *sym;
> @@ -425,7 +436,8 @@ static void check_conf(struct menu *menu)
>  		    (sym_is_choice(sym) && sym_get_tristate_value(sym) == yes)) {
>  			if (input_mode == listnewconfig) {
>  				if (sym->name && !sym_is_choice_value(sym)) {
> -					printf("%s%s\n", CONFIG_, sym->name);
> +					conf_write_symbol(stdout, sym,
> +					    &listnewconfig_printers, NULL);
>  				}
>  			} else if (input_mode != oldnoconfig) {
>  				if (!conf_cnt++)
> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> index 31d06da..6f2f3a4 100644
> --- a/scripts/kconfig/confdata.c
> +++ b/scripts/kconfig/confdata.c
> @@ -548,8 +548,8 @@ static struct conf_printer tristate_printer_cb =
>   *
>   */
>  
> -static void conf_write_symbol(FILE *fp, struct symbol *sym,
> -			      struct conf_printer *printer, void *printer_arg)
> +void conf_write_symbol(FILE *fp, struct symbol *sym,
> +		       struct conf_printer *printer, void *printer_arg)
>  {
>  	const char *str;
>