From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kbuild@vger.kernel.org,
Nikolai Kondrashov <spbnick@gmail.com>,
maximilian attems <max@stro.at>
Subject: Re: [PATCH] deb-pkg: Fix building outside of source tree (O=...).
Date: Wed, 02 Feb 2011 10:34:29 +0100 [thread overview]
Message-ID: <4D492525.20402@gmail.com> (raw)
In-Reply-To: <1295876501-805-1-git-send-email-nicolas.2p.debian@free.fr>
Le 24/01/2011 14:41, Nicolas de Pesloüan a écrit :
Hi Michal,
Any troubles with my patch? I still don't find it in any branchs of
git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild-2.6.git
It depends on commit 1b9a50d931a04ba007cc1a926fead3ff4b5afa9b, from Maximilian Attems, (in
for-next), because it changes the same lines in scripts/package/builddeb.
But, as the problem it fixes cause make deb-pkg to fail, it might be pushed to rc-fixes... ?
Do you want me to rebase it on rc-fixes? (This would cause a future merge to fail when applying the
patch from Maximilian, but...).
Nicolas.
> When building linux-headers package using deb-pkg, builddeb erroneously assume
> current directory is the source tree. This is not true if building in another
> directory, using make O=... deb-pkg.
>
> This patch fix this problem.
>
> Signed-off-by: Nicolas de Pesloüan<nicolas.2p.debian@free.fr>
Tested-by: Nikolai Kondrashov <spbnick@gmail.com>
Acked-by: maximilian attems <max@stro.at>
> ---
> scripts/package/builddeb | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index ebc6d6e..f6cbc3d 100644
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -238,12 +238,12 @@ EOF
> fi
>
> # Build header package
> -find . -name Makefile -o -name Kconfig\* -o -name \*.pl> /tmp/files$$
> -find arch/$SRCARCH/include include scripts -type f>> /tmp/files$$
> +(cd $srctree; find . -name Makefile -o -name Kconfig\* -o -name \*.pl> /tmp/files$$)
> +(cd $srctree; find arch/$SRCARCH/include include scripts -type f>> /tmp/files$$)
> (cd $objtree; find .config Module.symvers include scripts -type f>> /tmp/objfiles$$)
> destdir=$kernel_headers_dir/usr/src/linux-headers-$version
> mkdir -p "$destdir"
> -tar -c -f - -T /tmp/files$$ | (cd $destdir; tar -xf -)
> +(cd $srctree; tar -c -f - -T /tmp/files$$) | (cd $destdir; tar -xf -)
> (cd $objtree; tar -c -f - -T /tmp/objfiles$$) | (cd $destdir; tar -xf -)
> rm -f /tmp/files$$ /tmp/objfiles$$
> arch=$(dpkg --print-architecture)
next prev parent reply other threads:[~2011-02-02 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 13:41 [PATCH] deb-pkg: Fix building outside of source tree (O=...) Nicolas de Pesloüan
2011-01-26 9:52 ` maximilian attems
2011-02-02 9:34 ` Nicolas de Pesloüan [this message]
2011-02-02 9:51 ` maximilian attems
2011-02-04 14:12 ` Michal Marek
-- strict thread matches above, loose matches on Subject: below --
2011-01-26 8:46 Nikolai Kondrashov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D492525.20402@gmail.com \
--to=nicolas.2p.debian@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=max@stro.at \
--cc=mmarek@suse.cz \
--cc=spbnick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox