From: Dimitris Michailidis <dm@chelsio.com>
To: Jan Beulich <JBeulich@novell.com>
Cc: David Miller <davem@davemloft.net>,
divy@chelsio.com, linux-kbuild@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] cxgb{3,4}: streamline Kconfig options
Date: Thu, 24 Feb 2011 11:41:15 -0800 [thread overview]
Message-ID: <4D66B45B.2050604@chelsio.com> (raw)
In-Reply-To: <4D661E2702000078000336B5@vpn.id2.novell.com>
Jan Beulich wrote:
> As to that INET vs NET dependency - is it possible that the
> network drivers really just need NET, but the iSCSI ones need
> INET? In which case the only common dependency would be
> PCI - certainly not worth a custom helper option.
I see about a dozen network drivers that depend on INET. These may be the
result of cut&paste from other drivers' Kconfig entries rather than actual
dependencies. Also some of these drivers select or selected in the past
INET_LRO and that may have something to do with their INET dependency, not sure.
Reading the commit message that introduced CHELSIO_T3_DEPENDS, it talks of
hidden dependencies that select does not see. I am not sure which exactly
but since it's been a few years since that commit I'll try to see what the
situation is today without the *_DEPENDS symbols and let you know.
next prev parent reply other threads:[~2011-02-24 19:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 13:29 [PATCH] cxgb{3,4}: streamline Kconfig options Jan Beulich
2011-02-22 18:14 ` David Miller
2011-02-23 9:46 ` Jan Beulich
2011-02-23 20:27 ` David Miller
2011-02-24 8:00 ` Jan Beulich
2011-02-24 19:41 ` Dimitris Michailidis [this message]
2011-02-25 19:51 ` Dimitris Michailidis
2011-02-28 8:19 ` Jan Beulich
2011-02-28 21:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D66B45B.2050604@chelsio.com \
--to=dm@chelsio.com \
--cc=JBeulich@novell.com \
--cc=davem@davemloft.net \
--cc=divy@chelsio.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox