* [PATCH]Clean up CodingStyle for scripts/kconfig/gconf.c
@ 2011-03-22 14:38 Harry Wei
2011-03-23 1:28 ` Li Zefan
0 siblings, 1 reply; 3+ messages in thread
From: Harry Wei @ 2011-03-22 14:38 UTC (permalink / raw)
To: zippel, linux-kbuild, linux-kernel; +Cc: greg, joe, akpm
Hi us,
Clean up CodingStyle for scripts/kconfig/gconf.c.
Thanks.
Best Regards.
Harry Wei.
Signed-off-by: Harry Wei <harryxiyou@gmail.com>
---
scripts/kconfig/gconf.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
index 4558961..56da945 100644
--- a/scripts/kconfig/gconf.c
+++ b/scripts/kconfig/gconf.c
@@ -7,7 +7,7 @@
*/
#ifdef HAVE_CONFIG_H
-# include <config.h>
+#include <config.h>
#endif
#include "lkc.h"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH]Clean up CodingStyle for scripts/kconfig/gconf.c
2011-03-22 14:38 [PATCH]Clean up CodingStyle for scripts/kconfig/gconf.c Harry Wei
@ 2011-03-23 1:28 ` Li Zefan
2011-03-23 7:32 ` Michal Marek
0 siblings, 1 reply; 3+ messages in thread
From: Li Zefan @ 2011-03-23 1:28 UTC (permalink / raw)
To: zippel, linux-kbuild, linux-kernel, greg, joe, akpm
Harry Wei wrote:
> Hi us,
> Clean up CodingStyle for scripts/kconfig/gconf.c.
>
What makes you think this is a bad style? Does Documentation/CodingStyle say
so? Does checkpatch.pl make a complain? Do you really think this improves
readability? I don't think so, and actually it makes the code worse.
Run checkpatch.pl on this file, and you'll see lots of errors and warnings,
but pure codingstyle cleanup is rarely worth anything, so better don't do
that.
> Thanks.
> Best Regards.
> Harry Wei.
>
> Signed-off-by: Harry Wei <harryxiyou@gmail.com>
> ---
> scripts/kconfig/gconf.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/kconfig/gconf.c b/scripts/kconfig/gconf.c
> index 4558961..56da945 100644
> --- a/scripts/kconfig/gconf.c
> +++ b/scripts/kconfig/gconf.c
> @@ -7,7 +7,7 @@
> */
>
> #ifdef HAVE_CONFIG_H
> -# include <config.h>
> +#include <config.h>
> #endif
>
> #include "lkc.h"
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH]Clean up CodingStyle for scripts/kconfig/gconf.c
2011-03-23 1:28 ` Li Zefan
@ 2011-03-23 7:32 ` Michal Marek
0 siblings, 0 replies; 3+ messages in thread
From: Michal Marek @ 2011-03-23 7:32 UTC (permalink / raw)
To: Li Zefan; +Cc: zippel, linux-kbuild, linux-kernel, greg, joe, akpm
On 23.3.2011 02:28, Li Zefan wrote:
> Harry Wei wrote:
>> Hi us,
>> Clean up CodingStyle for scripts/kconfig/gconf.c.
>>
>
> What makes you think this is a bad style? Does Documentation/CodingStyle say
> so? Does checkpatch.pl make a complain? Do you really think this improves
> readability? I don't think so, and actually it makes the code worse.
This include can be removed completely, there is no config.h in kconfig.
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-03-23 7:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-22 14:38 [PATCH]Clean up CodingStyle for scripts/kconfig/gconf.c Harry Wei
2011-03-23 1:28 ` Li Zefan
2011-03-23 7:32 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox