Re: [PATCH 09/34] x86: Allow to override the ROOT_DEV variable

Valdis.Kletnieks
2011-04-12T03:28:00Z

[-- Attachment #1: Type: text/plain, Size: 611 bytes --]

On Mon, 11 Apr 2011 17:08:21 +0200, Michal Marek said:

> Like this?

> Subject: [PATCH] x86: Do not set the rood_dev field in bzImage

'rood'? ;)

> -# ROOT_DEV specifies the default root-device when making the image.
> -# This can be either FLOPPY, CURRENT, /dev/xxxx or empty, in which case
> -# the default of FLOPPY is used by 'build'.

Does the default of FLOPPY still get used after this patch, or is this a stale comment?
Also, I sort of expected to see more code removed that *used* the no-longer-passed
value of ROOT_DEV.

(All my boxes have grub pass a root=, so I don't have a dog in this fight...)

[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]