From: Stephen Boyd <sboyd@codeaurora.org>
To: Michal Marek <mmarek@suse.cz>, Roman Zippel <zippel@linux-m68k.org>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
Nir Tzachar <nir.tzachar@gmail.com>
Subject: Re: [PATCH] nconfig: Silence unused return values from wattrset
Date: Mon, 18 Apr 2011 15:38:56 -0700 [thread overview]
Message-ID: <4DACBD80.9080705@codeaurora.org> (raw)
In-Reply-To: <1302127669-15272-1-git-send-email-sboyd@codeaurora.org>
On 04/06/2011 03:07 PM, Stephen Boyd wrote:
> Ignore the return value from wattrset since we ignore the return
> value in nconf.gui.c as well.
>
> scripts/kconfig/nconf.c: In function 'print_function_line':
> scripts/kconfig/nconf.c:376: warning: value computed is not used
> scripts/kconfig/nconf.c:380: warning: value computed is not used
> scripts/kconfig/nconf.c:387: warning: value computed is not used
> scripts/kconfig/nconf.c: In function 'show_menu':
> scripts/kconfig/nconf.c:956: warning: value computed is not used
> scripts/kconfig/nconf.c:961: warning: value computed is not used
> scripts/kconfig/nconf.c:963: warning: value computed is not used
> scripts/kconfig/nconf.c:965: warning: value computed is not used
>
> Cc: Nir Tzachar <nir.tzachar@gmail.com>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
Ping? Nack? Ack?
> scripts/kconfig/nconf.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index db56377..488dd74 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -373,18 +373,18 @@ static void print_function_line(void)
> const int skip = 1;
>
> for (i = 0; i < function_keys_num; i++) {
> - wattrset(main_window, attributes[FUNCTION_HIGHLIGHT]);
> + (void) wattrset(main_window, attributes[FUNCTION_HIGHLIGHT]);
> mvwprintw(main_window, LINES-3, offset,
> "%s",
> function_keys[i].key_str);
> - wattrset(main_window, attributes[FUNCTION_TEXT]);
> + (void) wattrset(main_window, attributes[FUNCTION_TEXT]);
> offset += strlen(function_keys[i].key_str);
> mvwprintw(main_window, LINES-3,
> offset, "%s",
> function_keys[i].func);
> offset += strlen(function_keys[i].func) + skip;
> }
> - wattrset(main_window, attributes[NORMAL]);
> + (void) wattrset(main_window, attributes[NORMAL]);
> }
>
> /* help */
> @@ -953,16 +953,16 @@ static void show_menu(const char *prompt, const char *instructions,
> current_instructions = instructions;
>
> clear();
> - wattrset(main_window, attributes[NORMAL]);
> + (void) wattrset(main_window, attributes[NORMAL]);
> print_in_middle(stdscr, 1, 0, COLS,
> menu_backtitle,
> attributes[MAIN_HEADING]);
>
> - wattrset(main_window, attributes[MAIN_MENU_BOX]);
> + (void) wattrset(main_window, attributes[MAIN_MENU_BOX]);
> box(main_window, 0, 0);
> - wattrset(main_window, attributes[MAIN_MENU_HEADING]);
> + (void) wattrset(main_window, attributes[MAIN_MENU_HEADING]);
> mvwprintw(main_window, 0, 3, " %s ", prompt);
> - wattrset(main_window, attributes[NORMAL]);
> + (void) wattrset(main_window, attributes[NORMAL]);
>
> set_menu_items(curses_menu, curses_menu_items);
>
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-04-18 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 22:07 [PATCH] nconfig: Silence unused return values from wattrset Stephen Boyd
2011-04-18 22:38 ` Stephen Boyd [this message]
2011-04-19 7:22 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DACBD80.9080705@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=nir.tzachar@gmail.com \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox