From: Michal Marek <mmarek@suse.cz>
To: wharms@bfs.de
Cc: linux-kbuild@vger.kernel.org,
Thomas Sailer <t.sailer@alumni.ethz.ch>,
linux-hams@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 17/34] hdlcdrv: Drop __TIME__ usage
Date: Tue, 19 Apr 2011 12:56:50 +0200 [thread overview]
Message-ID: <4DAD6A72.2050809@suse.cz> (raw)
In-Reply-To: <4DAD614D.1060704@bfs.de>
On 19.4.2011 12:17, walter harms wrote:
> Am 05.04.2011 16:59, schrieb Michal Marek:
>> --- a/drivers/net/hamradio/hdlcdrv.c
>> +++ b/drivers/net/hamradio/hdlcdrv.c
>> @@ -749,7 +749,7 @@ EXPORT_SYMBOL(hdlcdrv_unregister);
>> static int __init hdlcdrv_init_driver(void)
>> {
>> printk(KERN_INFO "hdlcdrv: (C) 1996-2000 Thomas Sailer HB9JNX/AE4WA\n");
>> - printk(KERN_INFO "hdlcdrv: version 0.8 compiled " __TIME__ " " __DATE__ "\n");
>> + printk(KERN_INFO "hdlcdrv: version 0.8\n");
>> return 0;
>> }
>>
>
> Its a bit late but i am not a big fan of hard coded version id's.
> Does GIT provide something like that ? If not
> IMHO the line
> printk(KERN_INFO "hdlcdrv: version 0.8\n");
> can be removed.
OK, submit a separate patch then. I personally don't care about version
id's, as long as they do not embed any timestamp ;-).
Michal
next prev parent reply other threads:[~2011-04-19 10:56 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1302015561-21047-1-git-send-email-mmarek@suse.cz>
2011-04-05 14:58 ` [PATCH 01/34] kconfig: Do not record timestamp in auto.conf and autoconf.h Michal Marek
2011-04-05 18:57 ` Arnaud Lacombe
2011-04-06 7:37 ` Michal Marek
2011-04-06 16:25 ` Arnaud Lacombe
2011-04-06 20:39 ` Michal Marek
2011-04-18 13:04 ` Michal Marek
2011-04-05 14:58 ` [PATCH 02/34] kbuild: Call gzip with -n Michal Marek
2011-04-18 13:05 ` Michal Marek
2011-04-05 14:58 ` [PATCH 03/34] powerpc: " Michal Marek
2011-04-05 14:58 ` [PATCH 04/34] kbuild: Use the deterministic mode of ar Michal Marek
2011-04-18 13:05 ` Michal Marek
2011-04-05 14:58 ` [PATCH 05/34] powerpc: " Michal Marek
2011-04-05 14:58 ` [PATCH 06/34] kbuild: Drop unused LINUX_COMPILE_TIME and LINUX_COMPILE_DOMAIN macros Michal Marek
2011-04-18 13:05 ` Michal Marek
2011-04-05 14:58 ` [PATCH 07/34] kbuild: Allow to override LINUX_COMPILE_BY and LINUX_COMPILE_HOST macros Michal Marek
2011-04-05 15:52 ` Jack Stone
2011-04-05 18:09 ` Michal Marek
2011-04-11 15:04 ` [PATCH v2] " Michal Marek
2011-04-12 3:25 ` Valdis.Kletnieks
2011-04-12 9:01 ` Michal Marek
2011-04-18 13:05 ` Michal Marek
2011-04-05 14:58 ` [PATCH 08/34] initramfs: Use KBUILD_BUILD_TIMESTAMP for generated entries Michal Marek
2011-04-05 17:31 ` [08/34] " Milton Miller
2011-04-05 18:12 ` Michal Marek
2011-04-11 15:06 ` [PATCH v2] " Michal Marek
2011-04-18 13:06 ` Michal Marek
2011-04-05 14:58 ` [PATCH 09/34] x86: Allow to override the ROOT_DEV variable Michal Marek
2011-04-05 15:30 ` H. Peter Anvin
2011-04-06 7:47 ` Michal Marek
2011-04-11 15:08 ` Michal Marek
2011-04-12 3:25 ` Valdis.Kletnieks
2011-04-12 7:11 ` Paul Bolle
2011-04-12 3:39 ` H. Peter Anvin
2011-04-12 5:01 ` Paul Bolle
2011-04-12 9:57 ` Michal Marek
2011-04-12 10:40 ` Paul Bolle
2011-04-12 11:30 ` [PATCH v2] x86: Do not set the root_dev field in bzImage Michal Marek
2011-05-11 15:22 ` Michal Marek
2011-05-25 20:32 ` Michal Marek
2011-04-05 14:58 ` [PATCH 10/34] cyclades: Drop __TIME__ usage Michal Marek
2011-04-18 22:17 ` Michal Marek
2011-04-05 14:58 ` [PATCH 11/34] nozomi: " Michal Marek
2011-04-05 14:58 ` [PATCH 12/34] isdn/diva: " Michal Marek
2011-04-05 15:10 ` Armin Schindler
2011-04-05 15:37 ` Ben Hutchings
2011-04-05 16:07 ` Armin Schindler
2011-04-05 20:01 ` Sam Ravnborg
2011-04-05 19:17 ` Valdis.Kletnieks
2011-04-06 8:06 ` Michal Marek
2011-05-25 20:38 ` Michal Marek
2011-05-26 8:15 ` Armin Schindler
2011-05-26 8:29 ` Michal Marek
2011-04-05 14:59 ` [PATCH 13/34] media/radio-maxiradio: " Michal Marek
2011-04-18 22:18 ` Michal Marek
2011-04-05 14:59 ` [PATCH 14/34] media/cx231xx: " Michal Marek
2011-04-18 22:18 ` Michal Marek
2011-04-05 14:59 ` [PATCH 15/34] baycom: " Michal Marek
[not found] ` <1302015780.4124.53.camel@xbox360.hq.axsem.com>
2011-05-25 15:23 ` Michal Marek
2011-04-05 14:59 ` [PATCH 16/34] nand/denali: " Michal Marek
2011-04-05 15:02 ` Artem Bityutskiy
2011-04-05 15:10 ` Michal Marek
2011-04-05 15:15 ` Artem Bityutskiy
2011-04-05 14:59 ` [PATCH 17/34] hdlcdrv: " Michal Marek
2011-04-19 10:17 ` walter harms
2011-04-19 10:56 ` Michal Marek [this message]
[not found] ` <1302015790.4124.54.camel@xbox360.hq.axsem.com>
2011-05-25 15:24 ` Michal Marek
2011-04-05 14:59 ` [PATCH 18/34] wan/pc300: " Michal Marek
2011-05-25 20:43 ` Michal Marek
2011-05-25 20:44 ` David Miller
2011-04-05 14:59 ` [PATCH 19/34] rt2x00: " Michal Marek
2011-04-05 15:28 ` Gertjan van Wingerde
2011-04-05 18:37 ` Ivo Van Doorn
2011-04-05 14:59 ` [PATCH 20/34] parport: " Michal Marek
2011-04-05 20:00 ` Arnaud Giersch
2011-05-25 20:44 ` Michal Marek
2011-04-05 14:59 ` [PATCH 21/34] aacraid: " Michal Marek
2011-04-18 22:20 ` Michal Marek
2011-04-05 14:59 ` [PATCH 22/34] scsi/in2000: " Michal Marek
2011-04-18 22:20 ` Michal Marek
2011-04-05 14:59 ` [PATCH 23/34] scsi/wd33c93: " Michal Marek
2011-04-18 22:20 ` Michal Marek
2011-04-05 14:59 ` [PATCH 24/34] usb/u132-hcd: " Michal Marek
2011-04-05 14:59 ` [PATCH 25/34] usb/ftdi-elan: " Michal Marek
2011-04-05 17:50 ` Matthew Dharm
2011-04-05 18:13 ` Greg KH
2011-04-05 14:59 ` [PATCH 26/34] dlm: " Michal Marek
2011-05-25 20:47 ` Michal Marek
2011-05-25 20:47 ` David Teigland
2011-04-05 14:59 ` [PATCH 27/34] gfs2: " Michal Marek
2011-05-25 20:48 ` Michal Marek
2011-05-26 8:43 ` Steven Whitehouse
2011-05-26 9:08 ` Michal Marek
2011-04-05 14:59 ` [PATCH 28/34] atm: " Michal Marek
2011-05-25 20:49 ` Michal Marek
2011-05-25 21:39 ` David Miller
2011-04-05 14:59 ` [PATCH 29/34] tipc: " Michal Marek
2011-04-05 22:25 ` Paul Gortmaker
2011-04-05 14:59 ` [PATCH 30/34] rio: Drop __DATE__ usage Michal Marek
2011-04-18 22:21 ` Michal Marek
2011-04-05 14:59 ` [PATCH 31/34] edac: " Michal Marek
2011-04-18 22:21 ` Michal Marek
2011-04-05 14:59 ` [PATCH 32/34] pmcraid: " Michal Marek
2011-04-18 22:21 ` Michal Marek
2011-04-05 14:59 ` [PATCH 33/34] usb/lh7a40x_udc: " Michal Marek
2011-04-05 16:25 ` Russell King - ARM Linux
2011-04-06 8:23 ` Michal Marek
2011-04-05 14:59 ` [PATCH 34/34] checkpatch: Warn about usage of __DATE__, __TIME__ and __TIMESTAMP__ Michal Marek
2011-05-26 11:39 ` Michal Marek
2011-05-26 12:42 ` Andy Whitcroft
2011-05-05 15:22 ` [PATCH v2] powerpc: Use the deterministic mode of ar Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DAD6A72.2050809@suse.cz \
--to=mmarek@suse.cz \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=t.sailer@alumni.ethz.ch \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox