* [PATCH] kbuild: don't warn about linux/version.h not including itself
@ 2011-04-24 23:27 Peter Foley
2011-04-26 20:35 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: Peter Foley @ 2011-04-24 23:27 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-kbuild, mmarek
This patch makes checkversion.pl not warn that include/linux/version.h
dosen't include itself.
Signed-off-by: Peter Foley <pefoley2@verizon.net>
---
scripts/checkversion.pl | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scripts/checkversion.pl b/scripts/checkversion.pl
index b444e89..b9150c7 100755
--- a/scripts/checkversion.pl
+++ b/scripts/checkversion.pl
@@ -47,7 +47,7 @@ foreach my $file (@ARGV) {
}
# Report used version IDs without include?
- if ($fUseVersion && ! $iLinuxVersion) {
+ if ($fUseVersion && ! $iLinuxVersion && $file !~ "include/linux/version.h") {
print "$file: $.: need linux/version.h\n";
}
--
1.7.5.rc1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] kbuild: don't warn about linux/version.h not including itself
2011-04-24 23:27 [PATCH] kbuild: don't warn about linux/version.h not including itself Peter Foley
@ 2011-04-26 20:35 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2011-04-26 20:35 UTC (permalink / raw)
To: pefoley2; +Cc: linux-kernel, linux-kbuild
On 25.4.2011 01:27, Peter Foley wrote:
> This patch makes checkversion.pl not warn that include/linux/version.h
> dosen't include itself.
>
> Signed-off-by: Peter Foley <pefoley2@verizon.net>
> ---
> scripts/checkversion.pl | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/checkversion.pl b/scripts/checkversion.pl
> index b444e89..b9150c7 100755
> --- a/scripts/checkversion.pl
> +++ b/scripts/checkversion.pl
> @@ -47,7 +47,7 @@ foreach my $file (@ARGV) {
> }
>
> # Report used version IDs without include?
> - if ($fUseVersion && ! $iLinuxVersion) {
> + if ($fUseVersion && ! $iLinuxVersion && $file !~ "include/linux/version.h") {
A more obvious fix would be to check the filename right at the beginning
of the loop and skip to the next iteration if it is version.h. Also, you
should escape the '.' in the regexp.
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-26 20:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-24 23:27 [PATCH] kbuild: don't warn about linux/version.h not including itself Peter Foley
2011-04-26 20:35 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox