From: Peter Foley <pefoley2@verizon.net>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kbuild: fix sed error in export_report.pl
Date: Tue, 26 Apr 2011 17:10:51 -0400 [thread overview]
Message-ID: <4DB734DB.9000904@verizon.net> (raw)
In-Reply-To: <4DB6D959.6090008@suse.cz>
On 4/26/2011 10:40 AM, Michal Marek wrote:
> On 26.4.2011 01:51, Peter Foley wrote:
>> This patch fixes a sed error in export_report.pl by escaping a $.
>>
>> Signed-off-by: Peter Foley<pefoley2@verizon.net>
>> ---
>> scripts/export_report.pl | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/scripts/export_report.pl b/scripts/export_report.pl
>> index 04dce7c..91fa5a2 100644
>> --- a/scripts/export_report.pl
>> +++ b/scripts/export_report.pl
>> @@ -50,7 +50,7 @@ sub usage {
>> sub collectcfiles {
>> my @file
>> - = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed s/\.ko$/.mod.c/`;
>> + = `cat .tmp_versions/*.mod | grep '.*\.ko\$' | sed
>> s/\.ko\$/.mod.c/`;
>
> Please enclose the argument in single quotes instead.
>
> Michal
I tried doing that and still got:
perl /usr/src/git/scripts/export_report.pl
sed: -e expression #1, char 5: unterminated `s' command
Peter
prev parent reply other threads:[~2011-04-26 21:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-25 23:51 [PATCH] kbuild: fix sed error in export_report.pl Peter Foley
2011-04-26 6:40 ` Arnaud Lacombe
2011-04-26 14:17 ` Peter Foley
2011-04-26 14:27 ` Américo Wang
2011-04-26 14:40 ` Michal Marek
2011-04-26 21:10 ` Peter Foley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DB734DB.9000904@verizon.net \
--to=pefoley2@verizon.net \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox