From: Michal Marek <mmarek@suse.cz>
To: Arun Sharma <asharma@fb.com>
Cc: linux-kbuild@vger.kernel.org
Subject: Re: make rpm-pkg and version mismatch
Date: Wed, 04 May 2011 22:23:43 +0200 [thread overview]
Message-ID: <4DC1B5CF.3070803@suse.cz> (raw)
In-Reply-To: <20110503212706.GA26044@dev1756.snc6.facebook.com>
Dne 3.5.2011 23:27, Arun Sharma napsal(a):
>
> make rpm-pkg produces files that look like: kernel-2.6.39rc5-2.x86_64.rpm
> However, uname -r produces 2.6.39rc5 (-2 is missing).
>
> This differs from how some of the distributors are packaging the kernel.
> Their setup includes %{release} in uname -r.
Distributors have control over the kernel uname -r string. make rpm, on
the other hand, needs to work with both the vanilla version strings, as
well as any crazy suffixes the user comes up with. Hence it uses the
uname -v version number as the rpm release, which is always defined.
>
> One way to achive that is:
>
> --- a/scripts/setlocalversion
> +++ b/scripts/setlocalversion
> @@ -170,4 +170,8 @@ else
> fi
> fi
>
> +# Append the RPM release
> +release=`. ./scripts/mkversion`
> +res="${res}-${release}"
> +
Please don't do that. make rpm has to work with the version string set
by the kernel, not the other way around.
Michal
next prev parent reply other threads:[~2011-05-04 20:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-03 21:27 make rpm-pkg and version mismatch Arun Sharma
2011-05-04 20:23 ` Michal Marek [this message]
2011-05-04 20:44 ` Arun Sharma
2011-05-04 21:07 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DC1B5CF.3070803@suse.cz \
--to=mmarek@suse.cz \
--cc=asharma@fb.com \
--cc=linux-kbuild@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox