From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor.suse.de ([195.135.220.2]:51499 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932086Ab1EQToa (ORCPT ); Tue, 17 May 2011 15:44:30 -0400 Message-ID: <4DD2D017.8050609@suse.cz> Date: Tue, 17 May 2011 21:44:23 +0200 From: Michal Marek MIME-Version: 1.0 Subject: Re: [PATCH] kconfig: Only generate config_is_xxx for bool and tristate options References: <1305646532-29114-1-git-send-email-mmarek@suse.cz> <20110517180518.GC18699@game.jcrosoft.org> In-Reply-To: <20110517180518.GC18699@game.jcrosoft.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Jean-Christophe PLAGNIOL-VILLARD Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org On 17.5.2011 20:05, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 17:35 Tue 17 May , Michal Marek wrote: >> For strings and integers, the config_is_xxx macros are useless and >> sometimes misleading: > except if the interger or hex can be at 0 > so the config_is_ is usefull to known that it's enabled You can check if the option that the integer depends on is enabled. >> #define CONFIG_INITRAMFS_SOURCE "" >> #define config_is_initramfs_source() 1 > here agreed but I'm nor sure if it's a special case or if it will we the case > for most of the string Same here. Michal