Re: [PATCH] Kconfig: add warning about permission of config file

[Michal Marek <mmarek@suse.cz>]

On 24.5.2011 16:26, Hiromu Yakura wrote:
> Hello,
>
> On Fri, May 24, 2011 at 22:23, Michal Marek<mmarek@suse.cz>  wrote:
>> Arnaud's point is that your patch should not be necessary at all,
>> because kconfig already checks the return value of the fopen() call in
>> conf_write() and prints the above message if it fails. So do you have a
>> testcase where make<...>config without your patch returns without
>> error, but the configuration is not written?
> Sorry for misunderstanding.
> Indeed, make *config which use 'conf' (e.g. oldconfig, defconfig...)
> raise error.
> And only xconfig and gconfig don't write the configuration without
> error.

I see, qconf lacks a check for the return value of conf_write() in 
ConfigMainWindow::closeEvent(), gconf does check the return value, but 
only displays it in the bottom box of the main window instead of a 
message box. Neither of them return failure in the error case. These 
bugs should be indeed fixed. But I don't like the directory permission 
check, it only handles one case, but does not handle permission on the 
.config file itself with KCONFIG_OVERWRITECONFIG=1, ENOSPC and so on.

Michal