Re: [PATCH 09/34] x86: Allow to override the ROOT_DEV variable

Michal Marek
2011-04-06T07:47:44Z

On 5.4.2011 17:30, H. Peter Anvin wrote:
>> --- a/arch/x86/boot/Makefile
>> +++ b/arch/x86/boot/Makefile
>> @@ -13,7 +13,7 @@
>> # This can be either FLOPPY, CURRENT, /dev/xxxx or empty, in which case
>> # the default of FLOPPY is used by 'build'.
>>
>> -ROOT_DEV := CURRENT
>> +ROOT_DEV ?= CURRENT
>>
>> # If you want to preset the SVGA mode, uncomment the next line and
>> # set SVGA_MODE to whatever number you want.
>
> Is this a good thing? As far as I understand ?= it may mean picking
> something up from the outside environment.
>
> Since ROOT_DEV has been obsolete for 15 years or more, this would seem
> to be a needless new error mode.

So can we just set the default root device to (0, 0)?

Michal