Re: [PATCH 2/2] kconfig/nconf: prevent segfault on empty menu

Arnaud Lacombe
2011-07-12T20:49:32Z

Hi,

On Tue, Jul 12, 2011 at 4:17 PM, Andrej Gelenberg
<andrej.gelenberg@udo.edu> wrote:
> Hi,
>
> here is one more patch, which make empty title instead of "(null)".
>
No. You are breaking front-ends which either properly use the API and
make use menu_has_prompt() before getting the prompt with
menu_get_prompt(), or test for NULL pointer and act accordingly. Btw,
by doing this, you potentially breaking nconf too, and there is rarely
any need to modify the back-end to fix display issue in the front-end.

- Arnaud

ps: could you please send inlined patched, that a real pain to review. thanks.

> Regards,
> Andrej Gelenberg
>
> On 07/11/2011 11:50 AM, Nir Tzachar wrote:
>> On Mon, Jul 11, 2011 at 11:51 AM, Andrej Gelenberg
>> <andrej.gelenberg@udo.edu> wrote:
>>> Hello,
>>>
>>> it show already "There is no help available for this option." message on
>>> F2. Only caption could be better as just "(null)". Besides ignore the
>>> key is much better as segfault.
>>
>> I agree. Then just add a proper caption and thats it.
>>
>> Cheers.
>>
>>> Regards
>>> Andrej Gelenberg
>