Re: [PATCH] kconfig: Only generate config_is_xxx for bool and tristate options

Michal Marek
2011-05-25T13:35:56Z

On Tue, May 17, 2011 at 05:35:32PM +0200, Michal Marek wrote:
> For strings and integers, the config_is_xxx macros are useless and
> sometimes misleading:
>
> #define CONFIG_INITRAMFS_SOURCE ""
> #define config_is_initramfs_source() 1
>
> Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> Signed-off-by: Michal Marek <mmarek@suse.cz>
> ---
> scripts/kconfig/confdata.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)

I applied this to kbuild-2.6.git#kconfig, but I won't be sending this
and the config_is_xxx patch to Linus now. First, I'm a bit in hurry and
there have been proposals for either a different name of the macro, or a
different implementation, second, the fixdep fix is not here, so we
wouldn't be able to make use of the feature anyway. So let's settle on a
final solution for 2.6.41 or 3.1 or whatever comes second next.

Michal