Re: [RFC][PATCH 1/2] kconfig: Introduce KCONFIG(), KCONFIG_BUILTIN() and KCONFIG_MODULE()

Arnaud Lacombe
2011-07-26T18:48:51Z

Hi,

On Tue, Jul 26, 2011 at 2:28 PM, Randy Dunlap <rdunlap@xenotime.net> wrote:
> On Tue, 26 Jul 2011 20:28:05 +0200 Michal Marek wrote:
>
>> Dne 26.7.2011 17:04, Randy Dunlap napsal(a):
>> > On Tue, 26 Jul 2011 15:21:39 +0200 Michal Marek wrote:
>> >> On 26.7.2011 15:01, Américo Wang wrote:
>> >>> BTW, the name KCONFIG(CONFIG_NUMA) seems ugly.
>> >>
>> >> Suggest a better one :). The proposals so far:
>> >> config_is_numa() (breaks grep)
>> >
>> > explain, please.
>>
>> If you grep for CONFIG_FOO usage, you'll miss this alternate syntax.
>>
>
> Ack.
>
>>
>> >> CONFIGURED(CONFIG_NUMA)
>> >> ENABLED(CONFIG_NUMA)
>> >> KCONFIG(CONFIG_NUMA)
>> >
>> > CONFIG(NUMA) || CONFIG(NUMA_BUILTIN) || CONFIG(NUMA_MODULE)
>>
>> same problem.
>
> Yes, I sorta got that after I sent the email.
>
> I guess I prefer your ENABLED() syntax then.
>
we need to be careful about namespace pollution/collision.

- Arnaud