From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:52499 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772Ab1G0Nio (ORCPT ); Wed, 27 Jul 2011 09:38:44 -0400 Message-ID: <4E3014E2.40501@suse.cz> Date: Wed, 27 Jul 2011 15:38:42 +0200 From: Michal Marek MIME-Version: 1.0 Subject: Re: [RFC][PATCH 1/2] kconfig: Introduce KCONFIG(), KCONFIG_BUILTIN() and KCONFIG_MODULE() References: <4E1D9C25.8080300@suse.cz> <1311634718-32588-1-git-send-email-mmarek@suse.cz> <4E2EBF63.8050208@suse.cz> <20110726080443.62196869.rdunlap@xenotime.net> <4E2F0735.1070403@suse.cz> <20110726112824.b357c756.rdunlap@xenotime.net> <20110726213536.1f56f0e3.rdunlap@xenotime.net> <4E2FCE2A.3000909@suse.cz> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Arnaud Lacombe Cc: Randy Dunlap , =?ISO-8859-1?Q?Am=E9rico_Wang?= , linux-kbuild@vger.kernel.org, sam@ravnborg.org, linux-kernel@vger.kernel.org, plagnioj@jcrosoft.com On 27.7.2011 15:31, Arnaud Lacombe wrote: > Hi, > > On Wed, Jul 27, 2011 at 4:36 AM, Michal Marek wrote: >> On 27.7.2011 06:35, Randy Dunlap wrote: >>> >>> On Tue, 26 Jul 2011 20:42:04 -0400 Arnaud Lacombe wrote: >>>> >>>> On Tue, Jul 26, 2011 at 2:48 PM, Arnaud Lacombe >>>> wrote: >>>>> >>>>> On Tue, Jul 26, 2011 at 2:28 PM, Randy Dunlap >>>>> wrote: >>>>>> >>>>>> I guess I prefer your ENABLED() syntax then. >>>>>> >>>>> we need to be careful about namespace pollution/collision. >>>>> >>>> For the sake of having numbers: >>>> >>>> % git grep -w ENABLED . | wc -l >>>> 116 >>>> % git grep -w CONFIGURED . | wc -l >>>> 11 >>>> % git grep -w KCONFIG . | wc -l >>>> 1 >>> >>> OK. Then I would go back to a predicate like the original patch had, >>> e.g.: >>> IS_ENABLED(CONFIG_NUMA) >> >> Good idea. Is anyone against >> IS_ENABLED(CONFIG_FOO) >> IS_ENABLED_BUILTIN(CONFIG_FOO) >> IS_ENABLED_MODULE(CONFIG_FOO) >> ? >> > I'm good with the naming, but how would you define those ? I may have > trouble to discern between IS_ENABLED() and IS_ENABLED_BUILTIN(). IS_ENABLED() would mean not disabled, i.e. either 'y' or 'm'. IS_ENABLED_BUILTIN() would mean 'y' and only 'y' and IS_ENABLED_MODULE() would mean 'm'. For boolean options, IS_ENABLED() would be equivalent to IS_ENABLED_BUILTIN() and IS_ENABLED_MODULE() would be always false. Michal