From: Michal Marek <mmarek@suse.cz>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Arnaud Lacombe <lacombar@gmail.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig'
Date: Thu, 11 Aug 2011 10:58:27 +0200 [thread overview]
Message-ID: <4E4399B3.3020909@suse.cz> (raw)
In-Reply-To: <1313052168.18037.9.camel@i7.infradead.org>
On 11.8.2011 10:42, David Woodhouse wrote:
> On Wed, 2011-08-10 at 23:29 -0400, Arnaud Lacombe wrote:
>> how is that supposed to work with your other patches ?
>
> You cannot perform build targets with CONFIG symbols overridden.
>
>> % make CONFIG_NET=y allyesconfig drivers/ata/
> ^^^^^^^ override ^^^^^^^^^^ build target
>
>> Makefile:504: *** Cannot perform build targets with CONFIG symbols
>> overridden. Stop.
>
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ error message which
> told you that, if you'd been paying the slightest bit of attention
> rather than just making pointless noise.
I would much rather see include/config/auto.conf reset all configuration
variables to match what kconfig computed. I.e. use 'undefine CONFIG_FOO'
instead of '# CONFIG_FOO is not set'. Additionally print this for any
CONFIG_* variable found in the environment, even if the symbol is not
visible in the current configuration. The include/config/auto.conf file
is only used internally, so it should be safe to change the format.
Michal
next prev parent reply other threads:[~2011-08-11 8:58 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1312067499.22074.59.camel@i7.infradead.org>
2011-07-30 23:13 ` [PATCH 1/2] kconfig: Factor out conf_validate_choice_val() function from conf_read_simple() David Woodhouse
2011-07-31 2:17 ` Arnaud Lacombe
2011-07-31 22:21 ` David Woodhouse
2011-07-30 23:14 ` [PATCH 2/2] Enable 'make CONFIG_FOO=y oldconfig' David Woodhouse
2011-07-30 23:44 ` Arnaud Lacombe
2011-07-30 23:53 ` H. Peter Anvin
2011-07-31 0:05 ` Arnaud Lacombe
2011-07-31 0:29 ` H. Peter Anvin
2011-07-31 1:06 ` Arnaud Lacombe
2011-07-31 1:28 ` H. Peter Anvin
2011-07-31 2:09 ` Arnaud Lacombe
2011-07-31 5:21 ` Arnaud Lacombe
2011-07-31 22:18 ` David Woodhouse
2011-08-09 15:22 ` Arnaud Lacombe
2011-07-31 7:33 ` David Woodhouse
2011-07-31 16:37 ` Randy Dunlap
2011-07-31 16:57 ` David Woodhouse
2011-07-31 17:08 ` Randy Dunlap
2011-07-31 17:40 ` David Woodhouse
2011-08-09 14:14 ` Michal Marek
2011-08-09 15:26 ` Arnaud Lacombe
2011-08-10 12:59 ` Michal Marek
2011-08-10 13:07 ` David Woodhouse
2011-08-10 14:15 ` Arnaud Lacombe
2011-08-10 14:17 ` David Woodhouse
2011-08-10 14:34 ` Arnaud Lacombe
2011-08-10 16:33 ` David Woodhouse
2011-08-10 17:00 ` Emmanuel Deloget
2011-08-10 17:52 ` H. Peter Anvin
2011-08-10 17:44 ` Arnaud Lacombe
2011-08-10 17:54 ` H. Peter Anvin
2011-08-10 17:59 ` David Woodhouse
2011-08-10 18:40 ` Arnaud Lacombe
2011-08-10 18:52 ` David Woodhouse
2011-08-10 22:33 ` Arnaud Lacombe
2011-08-10 23:16 ` David Woodhouse
2011-08-11 3:29 ` Arnaud Lacombe
2011-08-11 8:42 ` David Woodhouse
2011-08-11 8:58 ` Michal Marek [this message]
2011-08-11 11:10 ` David Woodhouse
2011-08-11 11:15 ` Andreas Schwab
2011-08-11 11:40 ` David Woodhouse
2011-08-11 11:56 ` Michal Marek
2011-08-11 13:20 ` David Woodhouse
2011-08-11 14:57 ` Arnaud Lacombe
2011-08-11 15:07 ` David Woodhouse
2011-08-11 15:24 ` Michal Marek
2011-08-11 15:50 ` David Woodhouse
2011-08-10 17:01 ` Randy Dunlap
2011-08-10 17:25 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4399B3.3020909@suse.cz \
--to=mmarek@suse.cz \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox