* Kconfig: single-config-entry choice groups
@ 2011-10-10 20:02 Paul Bolle
2011-10-11 12:30 ` Michal Marek
0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2011-10-10 20:02 UTC (permalink / raw)
To: linux-kbuild
0) There seem to be about two dozen single-config-entry choice groups in
Kconfig files across the tree: choice groups that let one set exactly
one CONFIG option. (Most of the time hat CONFIG option is also the
choice group's default. That doesn't seem to matter, though. The default
could as well be some bogus symbol.)
1) These choice groups are not optional, so there's nothing to actually
choose. As far as I can see that single CONFIG option will always be
set.
2) Are single-config-entry choice groups some special, but undocumented,
idiom? Or are they perhaps the result of editing (ie, some of their
config entries where removed until there was just one left)? Or
something else?
Paul Bolle
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Kconfig: single-config-entry choice groups
2011-10-10 20:02 Kconfig: single-config-entry choice groups Paul Bolle
@ 2011-10-11 12:30 ` Michal Marek
2011-10-11 12:52 ` Paul Bolle
0 siblings, 1 reply; 3+ messages in thread
From: Michal Marek @ 2011-10-11 12:30 UTC (permalink / raw)
To: Paul Bolle; +Cc: linux-kbuild
On 10.10.2011 22:02, Paul Bolle wrote:
> 0) There seem to be about two dozen single-config-entry choice groups in
> Kconfig files across the tree: choice groups that let one set exactly
> one CONFIG option. (Most of the time hat CONFIG option is also the
> choice group's default. That doesn't seem to matter, though. The default
> could as well be some bogus symbol.)
>
> 1) These choice groups are not optional, so there's nothing to actually
> choose. As far as I can see that single CONFIG option will always be
> set.
>
> 2) Are single-config-entry choice groups some special, but undocumented,
> idiom?
My guess is that this is simply bitrot. Can you share the list of these
single-entry choice groups?
Michal
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Kconfig: single-config-entry choice groups
2011-10-11 12:30 ` Michal Marek
@ 2011-10-11 12:52 ` Paul Bolle
0 siblings, 0 replies; 3+ messages in thread
From: Paul Bolle @ 2011-10-11 12:52 UTC (permalink / raw)
To: Michal Marek; +Cc: linux-kbuild
On Tue, 2011-10-11 at 14:30 +0200, Michal Marek wrote:
> My guess is that this is simply bitrot. Can you share the list of these
> single-entry choice groups?
Sure. Note that I composed this list by simply manually inspecting every
choice group in the tree (thinking about a smarter way to do this would
have taken me much longer than that). I marked all these groups with
'XXX' in some temporary branch in my local repository. This makes these
Kconfig files invalid, of course. Grepping for 'choice XXX' now gives
me:
arch/arm/mach-imx/Kconfig:161:choice XXX
arch/arm/mach-imx/Kconfig:211:choice XXX
arch/arm/mach-imx/Kconfig:256:choice XXX
arch/arm/mach-imx/Kconfig:575:choice XXX
arch/arm/mach-mx5/Kconfig:102:choice XXX
arch/arm/mach-mx5/Kconfig:130:choice XXX
arch/arm/mach-tegra/Kconfig:5:choice XXX
arch/arm/plat-omap/Kconfig:210:choice XXX
arch/arm/plat-tcc/Kconfig:5:choice XXX
arch/avr32/Kconfig:168:choice XXX
arch/blackfin/mach-bf538/boards/Kconfig:1:choice XXX
arch/cris/arch-v32/Kconfig:102:choice XXX
arch/microblaze/platform/Kconfig.platform:8:choice XXX
arch/mips/bcm63xx/boards/Kconfig:1:choice XXX
arch/mips/jz4740/Kconfig:1:choice XXX
arch/openrisc/Kconfig:72:choice XXX
arch/sh/boards/mach-sdk7780/Kconfig:3:choice XXX
arch/sh/cchips/Kconfig:6:choice XXX
drivers/mtd/maps/Kconfig:90:choice XXX
I'm not sure whether this list is (correct and) complete.
Paul Bolle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-11 12:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-10 20:02 Kconfig: single-config-entry choice groups Paul Bolle
2011-10-11 12:30 ` Michal Marek
2011-10-11 12:52 ` Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox