Linux kbuild/kconfig development
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@xenotime.net>
To: Michal Marek <mmarek@suse.cz>,
	linux kbuild list <linux-kbuild@vger.kernel.org>
Subject: strange build failure when kconfig symbol is bool but not when tristate
Date: Fri, 14 Oct 2011 15:31:33 -0700	[thread overview]
Message-ID: <4E98B845.8050009@xenotime.net> (raw)

(my turn)

I have seen this randconfig build error 2-3 times in the past 3 months:
(this one is from linux-next of 20111014.)

net/built-in.o: In function `unregister_8022_client':
(.text+0x26157): undefined reference to `llc_sap_close'
net/built-in.o: In function `register_8022_client':
(.text+0x261b6): undefined reference to `llc_sap_open'
net/built-in.o: In function `p8022_request':
p8022.c:(.text+0x261e5): undefined reference to `llc_build_and_send_ui_pkt'
net/built-in.o: In function `snap_request':
psnap.c:(.text+0x26487): undefined reference to `llc_build_and_send_ui_pkt'
net/built-in.o: In function `snap_init':
psnap.c:(.init.text+0xb22): undefined reference to `llc_sap_open'
net/built-in.o: In function `snap_exit':
psnap.c:(.exit.text+0x16): undefined reference to `llc_sap_close'

I finally found that if I change drivers/net/tokenring/Kconfig
symbol TR from bool to tristate, the build completes successfully,
but I don't understand why this is happening.


---
 drivers/net/tokenring/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- next-2011-1014.orig/drivers/net/tokenring/Kconfig
+++ next-2011-1014/drivers/net/tokenring/Kconfig
@@ -4,7 +4,7 @@
 
 # So far, we only have PCI, ISA, and MCA token ring devices
 menuconfig TR
-	bool "Token Ring driver support"
+	tristate "Token Ring driver support"
 	depends on NETDEVICES && !UML
 	depends on (PCI || ISA || MCA || CCW || PCMCIA)
 	select LLC

> make oldconfig

> diff -u .config.old .config
--- .config.old	2011-10-14 15:17:45.000000000 -0700
+++ .config	2011-10-14 15:24:45.000000000 -0700
@@ -876,7 +876,7 @@
 # CONFIG_MDIO_BITBANG is not set
 # CONFIG_PPP is not set
 # CONFIG_SLIP is not set
-CONFIG_TR=y
+CONFIG_TR=m
 CONFIG_PCMCIA_IBMTR=m


voila.  build works cleanly.

ideas?

thanks,
-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

             reply	other threads:[~2011-10-14 22:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-14 22:31 Randy Dunlap [this message]
2011-10-14 22:54 ` strange build failure when kconfig symbol is bool but not when tristate Michal Marek
2011-10-15  0:20   ` Randy Dunlap
2011-10-15  5:39 ` Arnaud Lacombe
2011-10-15  5:52   ` Randy Dunlap
2011-10-15  6:08     ` Arnaud Lacombe
2011-11-11 16:55       ` Randy Dunlap
2011-11-20 13:59         ` Michal Marek
2011-11-20 17:39           ` Randy Dunlap
2011-11-20 18:02             ` Arnaud Lacombe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E98B845.8050009@xenotime.net \
    --to=rdunlap@xenotime.net \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=mmarek@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox