From: Michal Marek <mmarek@suse.cz>
To: Cheng Renquan <crquan@gmail.com>
Cc: linux-kbuild@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] headers_install: avoid those .install & ..install.cmd unused files
Date: Sat, 10 Dec 2011 15:43:28 +0100 [thread overview]
Message-ID: <4EE37010.6060207@suse.cz> (raw)
In-Reply-To: <CAH5vBdJ=Ws7FvO-KXUmOvg6jTuGCX9mZG77A8-38g1Lh=CchnA@mail.gmail.com>
On 3.12.2011 10:24, Cheng Renquan wrote:
> The modules_install, firmware_install, all install commands
> don't generate such hidden unused files under destination;
> I think headers_install also should not to generate such .install
> & ..install.cmd files;
> Usually, we call "make headers_install INSTALL_HDR_PATH=/some/path"
> expecting it install just the header files, not those dot files;
>
> The original "call if_changed" could generate ..install.cmd and
> together with "touch .install" could make the 2nd time headers_install
> quite faster but it's not meaningful here, because we usually only install once;
I think it makes sense for any *_install target to run the whole install
sequence. The slight problem is that headers_check has an explicit
dependency on headers_install, so someone doing
make headers_install && make headers_check
might not like the change.
> diff --git a/scripts/Makefile.headersinst b/scripts/Makefile.headersinst
> index a57f5bd..b3deff2 100644
> --- a/scripts/Makefile.headersinst
> +++ b/scripts/Makefile.headersinst
> @@ -54,8 +54,7 @@ quiet_cmd_install = INSTALL $(printdir) ($(words
> $(all-files))\
> $(PERL) $< $(objtree)/$(obj) $(install) $(SRCARCH) $(objhdr-y); \
> for F in $(wrapper-files); do \
> echo "\#include <asm-generic/$$F>" > $(install)/$$F; \
> - done; \
> - touch $@
> + done
If you are removing the .install marker, then please also remove any
reference to it from the makefile.
Michal
prev parent reply other threads:[~2011-12-10 14:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-03 9:24 [PATCH] headers_install: avoid those .install & ..install.cmd unused files Cheng Renquan
2011-12-10 14:43 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE37010.6060207@suse.cz \
--to=mmarek@suse.cz \
--cc=crquan@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).