linux-kbuild.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* -I option expansion and -Wmissing-include-dirs
@ 2011-11-25 13:46 Kirill A. Shutemov
  2011-12-11 20:59 ` Michal Marek
  0 siblings, 1 reply; 2+ messages in thread
From: Kirill A. Shutemov @ 2011-11-25 13:46 UTC (permalink / raw)
  To: linux-kbuild

Hi,

Currently, kbuild makes -I option expansion without any check if the
resulting include directory exists. It produce warnings if you try to build
with W=1 which enables -Wmissing-include-dirs. For example:

$ make W=1 O=~/var/tmp drivers/gpu/drm/drm_auth.o
  Using /home/space/kas/git/public/linux as source for kernel
  GEN     /home/space/kas/var/tmp1/Makefile
  CHK     include/linux/version.h
  CHK     include/generated/utsrelease.h
  CALL    /home/space/kas/git/public/linux/scripts/checksyscalls.sh
  CC [M]  drivers/gpu/drm/drm_auth.o
cc1: warning: include/drm: No such file or directory [enabled by default]

It would be nice to address the issue.

P.S. [enabled by default] is gcc bug. [-Wmissing-include-dirs] should be there.
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51303

-- 
 Kirill A. Shutemov

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: -I option expansion and -Wmissing-include-dirs
  2011-11-25 13:46 -I option expansion and -Wmissing-include-dirs Kirill A. Shutemov
@ 2011-12-11 20:59 ` Michal Marek
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2011-12-11 20:59 UTC (permalink / raw)
  To: Kirill A. Shutemov; +Cc: linux-kbuild

On 25.11.2011 14:46, Kirill A. Shutemov wrote:
> Hi,
> 
> Currently, kbuild makes -I option expansion without any check if the
> resulting include directory exists. It produce warnings if you try to build
> with W=1 which enables -Wmissing-include-dirs. For example:
> 
> $ make W=1 O=~/var/tmp drivers/gpu/drm/drm_auth.o
>   Using /home/space/kas/git/public/linux as source for kernel
>   GEN     /home/space/kas/var/tmp1/Makefile
>   CHK     include/linux/version.h
>   CHK     include/generated/utsrelease.h
>   CALL    /home/space/kas/git/public/linux/scripts/checksyscalls.sh
>   CC [M]  drivers/gpu/drm/drm_auth.o
> cc1: warning: include/drm: No such file or directory [enabled by default]
> 
> It would be nice to address the issue.

That's not a kbuild bug but a drm Makefile bug. It should be passing
-I$(src)/include/drm. But it apparently builds even with the wrong
argument, so it can probably go away.

Michal


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-12-11 20:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-25 13:46 -I option expansion and -Wmissing-include-dirs Kirill A. Shutemov
2011-12-11 20:59 ` Michal Marek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).