* Re: [PATCH] mm: add config NUMA stub to all architectures [not found] ` <CAMuHMdUYCGoZoUHWMtMCwAJ2ofweaeLF3U89P5EvrNGcn=6apw@mail.gmail.com> @ 2012-02-19 18:12 ` Randy Dunlap 2012-02-19 23:21 ` Arnaud Lacombe 0 siblings, 1 reply; 3+ messages in thread From: Randy Dunlap @ 2012-02-19 18:12 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Andrew Morton, Konstantin Khlebnikov, Stephen Rothwell, linux-next, LKML, Sam Ravnborg, Michal Marek, linux-kbuild On 02/19/2012 09:01 AM, Geert Uytterhoeven wrote: > On Fri, Feb 17, 2012 at 21:30, Andrew Morton<akpm@linux-foundation.org> wrote: >> On Fri, 17 Feb 2012 16:08:15 +0400 >> Konstantin Khlebnikov<khlebnikov@openvz.org> wrote: >> >>> Config NUMA must be defined for all architectures, >>> otherwise IS_ENABLED(CONFIG_NUMA) does not work. >>> Some arch-specific Kconfig already has this stub. >>> This patch adds it to all remaining. >> >> It would be better to teach IS_ENABLED() to handle this situation. I >> don't think there's a way of doing this with cpp :( >> >> This limitation makes IS_ENABLED pretty dangerous, doesn't it? It >> makes it very easy to introduce build breakage with unexpected Kconfig >> combinations. > > Indeed. Recently I discovered IS_ENABLED() and started recommending it > to people for new code. But now I've seen the CONFIG_NUMA breakage, > I no longer think this is a good recommendation. adding Michal & linux-kbuild to cc: list. -- ~Randy ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: add config NUMA stub to all architectures 2012-02-19 18:12 ` [PATCH] mm: add config NUMA stub to all architectures Randy Dunlap @ 2012-02-19 23:21 ` Arnaud Lacombe 2012-02-20 14:24 ` Michal Marek 0 siblings, 1 reply; 3+ messages in thread From: Arnaud Lacombe @ 2012-02-19 23:21 UTC (permalink / raw) To: Randy Dunlap Cc: Geert Uytterhoeven, Andrew Morton, Konstantin Khlebnikov, Stephen Rothwell, linux-next, LKML, Sam Ravnborg, Michal Marek, linux-kbuild Hi, On Sun, Feb 19, 2012 at 1:12 PM, Randy Dunlap <rdunlap@xenotime.net> wrote: > On 02/19/2012 09:01 AM, Geert Uytterhoeven wrote: >> >> On Fri, Feb 17, 2012 at 21:30, Andrew Morton<akpm@linux-foundation.org> >> wrote: >>> >>> On Fri, 17 Feb 2012 16:08:15 +0400 >>> Konstantin Khlebnikov<khlebnikov@openvz.org> wrote: >>> >>>> Config NUMA must be defined for all architectures, >>>> otherwise IS_ENABLED(CONFIG_NUMA) does not work. >>>> Some arch-specific Kconfig already has this stub. >>>> This patch adds it to all remaining. >>> >>> >>> It would be better to teach IS_ENABLED() to handle this situation. I >>> don't think there's a way of doing this with cpp :( >>> >>> This limitation makes IS_ENABLED pretty dangerous, doesn't it? It >>> makes it very easy to introduce build breakage with unexpected Kconfig >>> combinations. >> >> >> Indeed. Recently I discovered IS_ENABLED() and started recommending it >> to people for new code. But now I've seen the CONFIG_NUMA breakage, >> I no longer think this is a good recommendation. > > adding Michal & linux-kbuild to cc: list. > I do not really see any way to fix this, beside having a unique architecture-wide configuration namespace :/ - Arnaud ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: add config NUMA stub to all architectures 2012-02-19 23:21 ` Arnaud Lacombe @ 2012-02-20 14:24 ` Michal Marek 0 siblings, 0 replies; 3+ messages in thread From: Michal Marek @ 2012-02-20 14:24 UTC (permalink / raw) To: Arnaud Lacombe Cc: Randy Dunlap, Geert Uytterhoeven, Andrew Morton, Konstantin Khlebnikov, Stephen Rothwell, linux-next, LKML, Sam Ravnborg, linux-kbuild On 20.2.2012 00:21, Arnaud Lacombe wrote: > On Sun, Feb 19, 2012 at 1:12 PM, Randy Dunlap <rdunlap@xenotime.net> wrote: >> On 02/19/2012 09:01 AM, Geert Uytterhoeven wrote: >>> >>> On Fri, Feb 17, 2012 at 21:30, Andrew Morton<akpm@linux-foundation.org> >>> wrote: >>>> It would be better to teach IS_ENABLED() to handle this situation. I >>>> don't think there's a way of doing this with cpp :( >>>> >>>> This limitation makes IS_ENABLED pretty dangerous, doesn't it? It >>>> makes it very easy to introduce build breakage with unexpected Kconfig >>>> combinations. >>> >>> >>> Indeed. Recently I discovered IS_ENABLED() and started recommending it >>> to people for new code. But now I've seen the CONFIG_NUMA breakage, >>> I no longer think this is a good recommendation. >> >> adding Michal & linux-kbuild to cc: list. >> > I do not really see any way to fix this, beside having a unique > architecture-wide configuration namespace :/ Having a single namespace, or less ambitiously, having less arch-specific config symbol definitions, would be a plus. IS_ENABLED requiring the symbol to be defined is not bad per se, it prevents typos. Michal ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-20 14:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4F3E42E0.4030108@openvz.org>
[not found] ` <20120217120815.25909.15632.stgit@zurg>
[not found] ` <20120217123037.ecfc5dd9.akpm@linux-foundation.org>
[not found] ` <CAMuHMdUYCGoZoUHWMtMCwAJ2ofweaeLF3U89P5EvrNGcn=6apw@mail.gmail.com>
2012-02-19 18:12 ` [PATCH] mm: add config NUMA stub to all architectures Randy Dunlap
2012-02-19 23:21 ` Arnaud Lacombe
2012-02-20 14:24 ` Michal Marek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox