From: Bernhard Walle <bernhard@bwalle.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: mmarek@suse.cz, lacombar@gmail.com, linux-kernel@vger.kernel.org,
linux-kbuild <linux-kbuild@vger.kernel.org>,
zippel@linux-m68k.org
Subject: Re: [PATCH] scripts/Kbuild.include: Fix portability problem of "echo -e"
Date: Sun, 26 Feb 2012 18:51:34 +0100 [thread overview]
Message-ID: <4F4A7126.6020009@bwalle.de> (raw)
In-Reply-To: <20120226174805.GA562@merkur.ravnborg.org>
Am 26.02.12 18:48, schrieb Sam Ravnborg:
>> > --- a/scripts/Kbuild.include
>> > +++ b/scripts/Kbuild.include
>> > @@ -104,7 +104,7 @@ as-option = $(call try-run,\
>> > # Usage: cflags-y += $(call as-instr,instr,option1,option2)
>> >
>> > as-instr = $(call try-run,\
>> > - /bin/echo -e "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3))
>> > + printf "%b\n" "$(1)" | $(CC) $(KBUILD_AFLAGS) -c -xassembler -o "$$TMP" -,$(2),$(3))
>> >
>> > # cc-option
>> > # Usage: cflags-y += $(call cc-option,-march=winchip-c6,-march=i586)
> Roman Zippel removed use of printf in this patch: beda9f3a13bbb22cde92a45f230a02ef2afef6a9
>
> I cannot remember why - but it would be good if you could dig up
> why - just so we do not hit an old issue again.
Well, he used printf "$(1)", that's different from printf "%b\n" "$(1)"
since format strings inside $(1) would be interpreted.
But maybe Roman can comment on that? Cc'ing him.
Regards,
Bernhard
next prev parent reply other threads:[~2012-02-26 17:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1330277718-2667-1-git-send-email-bernhard@bwalle.de>
2012-02-26 17:48 ` [PATCH] scripts/Kbuild.include: Fix portability problem of "echo -e" Sam Ravnborg
2012-02-26 17:51 ` Bernhard Walle [this message]
2012-02-26 21:05 ` Sam Ravnborg
2012-03-19 17:44 ` Bernhard Walle
2012-03-24 22:33 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4A7126.6020009@bwalle.de \
--to=bernhard@bwalle.de \
--cc=lacombar@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=sam@ravnborg.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox